New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/2318/migrate code map services #3094
Merged
shaman-apprentice
merged 9 commits into
main
from
refactor/2318/migrate-code-map-services
Oct 20, 2022
Merged
Refactor/2318/migrate code map services #3094
shaman-apprentice
merged 9 commits into
main
from
refactor/2318/migrate-code-map-services
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaman-apprentice
force-pushed
the
refactor/2318/migrate-code-map-services
branch
3 times, most recently
from
October 16, 2022 20:40
f83f309
to
940e396
Compare
and clean up internal not needed vars and improve tests which worked by accident ref #2318 refactor: squash me
shaman-apprentice
force-pushed
the
refactor/2318/migrate-code-map-services
branch
from
October 18, 2022 18:35
ffc3b19
to
ae1a9b5
Compare
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
Hall-Ma
reviewed
Oct 19, 2022
Hall-Ma
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate:
remove now obsolete:
ref #2318