Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate code map services #3094

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Refactor/2318/migrate code map services #3094

merged 9 commits into from
Oct 20, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Oct 16, 2022 •
edited

migrate:

  • codeMap.render.service.ts
  • codeMap.label.service.ts
  • codeMap.mouseEvent.service.ts
  • codeMap.arrow.service.ts
  • codeCharta.service

remove now obsolete:

  • sharpnessMode.service
  • isLoadingFile.service
  • scaling.service
  • experimentalFeaturesEnabled.service

ref #2318

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/migrate-code-map-services branch 3 times, most recently from f83f309 to 940e396 Compare October 16, 2022 20:40
@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/migrate-code-map-services branch from ffc3b19 to ae1a9b5 Compare October 18, 2022 18:35
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

95.4% 95.4% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Hall-Ma
Hall-Ma approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shaman-apprentice shaman-apprentice merged commit 418fda2 into main Oct 20, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-code-map-services branch October 20, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaman-apprentice @Hall-Ma