fix : add some code to reset the color in delta mode #3368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csu-it-worker
changed the title
ce-bo
reviewed
Sep 18, 2023
CHANGELOG.md
Outdated
| @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/) | |||
|
|
|||
| ## [unreleased] (Added 🚀 | Changed | Removed 🗑 | Fixed 🐞 | Chore 👨💻 👩💻) | |||
|
|
|||
| ## [1.120.0] - 2023-09-17 | |||
There was a problem hiding this comment.
This will be set during building the release.
Suggested change
| ## [1.120.0] - 2023-09-17 |
ce-bo
reviewed
Sep 18, 2023
| @@ -70,7 +72,10 @@ export class CodeMapBuilding { | |||
|
|
|||
| resetColor() { | |||
| this._color = this._defaultColor | |||
| this._deltaColor = this._defaultDeltaColor | |||
| // this._deltaColor = this._defaultDeltaColor | |||
There was a problem hiding this comment.
Suggested change
| // this._deltaColor = this._defaultDeltaColor |
There was a problem hiding this comment.
Sorry for not noticing this suggested change
ce-bo
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Hi @csu-it-worker , thank you very much for fixing this :-)
I tested the changes and would like to merge it after the changelog is fixed.
|
@csu-it-worker any update on this? |
yes, I made the suggested changes |
in delta mode, add a filed to record the original color (red or green), and call method "resetColor()" to reset the color when the building loses focus
|
@csu-it-worker sorry for the silence. I need to adjust a few tests to apply this fix. I will look into this after the angular 16 update is done. Thanks again for the hint on the fix 🙏 |
|
Fixed via #3426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some code to reset the color #3348
Closes: #3348
Description
Resolve the bug : Deselected buildings with green/red roof in delta mode do not reset their color roof
Add a filed to record the original color (red or green)
Call method "resetColor()" to reset the color when the building loses focus In delta mode
Screenshots or gifs