Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3348/deselect building reset color #3426

Merged
merged 8 commits into from Dec 5, 2023
Merged

Fix/3348/deselect building reset color #3426

merged 8 commits into from Dec 5, 2023

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Dec 4, 2023 •
edited

Fix select color not correctly resetting on unselect in delta mode

Closes: #3348

Description

  • Change defaultDeltaColor to be the true default / backup color for select/unselect (like it is handled in non-delta mode)
  • Add onclick method to CodeMapBuilding for selection process (avoid override of default value)
    • This is necessary because the delta colors get set on existing buildings and not while being constructed (like in non-delta mode)

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualisation READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

@phanlezz phanlezz force-pushed the fix/3348/deselect-building-reset-color branch from 4b2c8d5 to 5342ce1 Compare December 4, 2023 14:16
Nereboss
Nereboss approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@phanlezz phanlezz merged commit 8cb60c1 into main Dec 5, 2023
7 checks passed
@phanlezz phanlezz deleted the fix/3348/deselect-building-reset-color branch December 5, 2023 10:20
@phanlezz phanlezz mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereboss Nereboss Nereboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deselected buildings with green/red roof in delta mode do not reset their color roof
2 participants
@phanlezz @Nereboss