Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCData::stringWithDetectedCharset doesn't work properly with html encoded with windows-1251 #989

Closed
foxinushka opened this issue Nov 28, 2014 · 7 comments
Closed

MCData::stringWithDetectedCharset doesn't work properly with html encoded with windows-1251 #989

foxinushka opened this issue Nov 28, 2014 · 7 comments

Comments

@foxinushka
Copy link
Contributor

If you call the method with args:

hintCharset = windows-1251
isHTML = true

it tries to decode string with UTF-8 encoding.

The line: charset = charsetWithFilteredHTML(isHTML, hintCharset) sets charset to utf-8.
@dinhvh
Copy link
Member

dinhvh commented Nov 29, 2014

Could you make the content available as a downloadable file?

@foxinushka
Copy link
Contributor Author

https://www.evernote.com/shard/s202/sh/972a7033-7a4c-4800-83a1-5898d6b07c51/6cd7df3639e0b7245c3b7a0fac290047

@foxinushka
Copy link
Contributor Author

Any news? Do you reproduce an issue with my file?

@dinhvh
Copy link
Member

dinhvh commented Dec 4, 2014

If you need faster track for analyze, please look for consulting via Astro HQ.

@foxinushka foxinushka mentioned this issue Dec 16, 2014
Closed
@dinhvh dinhvh reopened this Dec 16, 2014
@dinhvh
Copy link
Member

dinhvh commented Dec 18, 2014

Is it the correct output for the file you attached?
https://gist.github.com/dinhviethoa/2645e07ddb1335a61227
That's what the current codebase of mailcore2 will output.

@dinhvh
Copy link
Member

dinhvh commented Dec 18, 2014

Fixed with c1607b6.

@dinhvh dinhvh closed this as completed Dec 18, 2014
@foxinushka
Copy link
Contributor Author

Yes, it is correct output for my file.

@siberianisaev siberianisaev mentioned this issue Jun 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dinhvh @foxinushka