Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve client config logic regarding http option #31

Closed
PaulLeCam opened this issue Aug 31, 2018 · 0 comments
Closed

Improve client config logic regarding http option #31

PaulLeCam opened this issue Aug 31, 2018 · 0 comments
Assignees
@PaulLeCam
Labels
bzz
Milestone
v0.4

Comments

@PaulLeCam
Copy link
Collaborator

The Client constructor has some logic trying to be "smart" regarding what was provided, supporting APIs, RPC instances and plain strings.
The http option is confusing at the moment because it can be used to connect to the Swarm BZZ API, but potentially also an Ethereum HTTP gateway, so this should be refactored to be explicit either way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulLeCam PaulLeCam

Labels
bzz
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
1 participant
@PaulLeCam