MAISTRA-1352 remove unused helm templates #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
jwendell
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
LGTM
My only comment is that now we have some stuff being done within patch-charts.sh (removal of files) and others in the Makefile. I dream with the day we can see this:
diff --git a/build/patch-charts.sh b/build/patch-charts.sh
deleted file mode 100755
index 57b33e65..00000000
--- a/build/patch-charts.sh
+++ /dev/null
|
Yeah, I did that out of expediency, and because I didn't want to have to update maistra-1.0 branch. Eventually, we should push the relevant changes down into the maistra-1.0 branch. (#405 is even worse, since the changes only apply to the 1.1.1 operator, even though they're 1.0.x charts.) |
luksa
approved these changes
May 5, 2020
dgn
approved these changes
May 26, 2020
|
@rcernich I think this needs to be rebased to pass gen-check. |
|
/retest |
Signed-off-by: rcernich <rcernich@redhat.com>
|
@mergify refresh |
|
@Mergifyio refresh |
|
Command Hey, I reacted but my real name is @Mergifyio |
|
Command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rcernich rcernich@redhat.com