Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: Makie.MakieLayout is deprecated #3072

Closed
prbzrg opened this issue Jul 18, 2023 · 4 comments
Closed

WARNING: Makie.MakieLayout is deprecated #3072

prbzrg opened this issue Jul 18, 2023 · 4 comments
Labels

Comments

@prbzrg
Copy link

prbzrg commented Jul 18, 2023

I got these warnings in the precompilation:

┌ GLMakie [e9467ef8-e4e7-5192-8a1a-b1aee30e663a]
│  WARNING: Makie.MakieLayout is deprecatedThe module `MakieLayout` has been removed and integrated into Makie, so simply replace all usage of `MakieLayout` with `Makie`.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.MakieLayout into GLMakie.
│  WARNING: Makie._alternative_fonts is deprecated, use ALTERNATIVE_FONTS instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._alternative_fonts into GLMakie.
│  WARNING: Makie._current_figure is deprecated, use CURRENT_FIGURE instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._current_figure into GLMakie.
│  WARNING: Makie._default_font is deprecated, use DEFAULT_FONT instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._default_font into GLMakie.
│  WARNING: Makie.default_palettes is deprecated, use DEFAULT_PALETTES instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.default_palettes into GLMakie.
│  WARNING: Makie.minimal_default is deprecated, use MAKIE_DEFAULT_THEME instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.minimal_default into GLMakie.
└
┌ CairoMakie [13f3f980-e62b-5c42-98c6-ff1f3baf88f0]
│  WARNING: Makie.MakieLayout is deprecatedThe module `MakieLayout` has been removed and integrated into Makie, so simply replace all usage of `MakieLayout` with `Makie`.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.MakieLayout into CairoMakie.
│  WARNING: Makie._alternative_fonts is deprecated, use ALTERNATIVE_FONTS instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._alternative_fonts into CairoMakie.
│  WARNING: Makie._current_figure is deprecated, use CURRENT_FIGURE instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._current_figure into CairoMakie.
│  WARNING: Makie._default_font is deprecated, use DEFAULT_FONT instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._default_font into CairoMakie.
│  WARNING: Makie.default_palettes is deprecated, use DEFAULT_PALETTES instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.default_palettes into CairoMakie.
│  WARNING: Makie.minimal_default is deprecated, use MAKIE_DEFAULT_THEME instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.minimal_default into CairoMakie.
└
┌ WGLMakie [276b4fcb-3e11-5398-bf8b-a0c2d153d008]
│  WARNING: Makie.MakieLayout is deprecatedThe module `MakieLayout` has been removed and integrated into Makie, so simply replace all usage of `MakieLayout` with `Makie`.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.MakieLayout into WGLMakie.
│  WARNING: Makie._alternative_fonts is deprecated, use ALTERNATIVE_FONTS instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._alternative_fonts into WGLMakie.
│  WARNING: Makie._current_figure is deprecated, use CURRENT_FIGURE instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._current_figure into WGLMakie.
│  WARNING: Makie._default_font is deprecated, use DEFAULT_FONT instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._default_font into WGLMakie.
│  WARNING: Makie.default_palettes is deprecated, use DEFAULT_PALETTES instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.default_palettes into WGLMakie.
│  WARNING: Makie.minimal_default is deprecated, use MAKIE_DEFAULT_THEME instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.minimal_default into WGLMakie.
│  ┌ Warning: `um(tag, args...; kw...)` is deprecated, use `m(tag, args...; kw...)` instead.
│  │   caller = three_display(session::JSServe.Session{JSServe.NoConnection}, scene::Makie.Scene; screen_config::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) at three_plot.jl:48
│  └ @ WGLMakie C:\Users\Hossein Pourbozorg\.julia\packages\WGLMakie\3HpV9\src\three_plot.jl:48
┌ RPRMakie [22d9f318-5e34-4b44-b769-6e3734a732a6]
│  WARNING: Makie.MakieLayout is deprecatedThe module `MakieLayout` has been removed and integrated into Makie, so simply replace all usage of `MakieLayout` with `Makie`.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.MakieLayout into RPRMakie.
│  WARNING: Makie._alternative_fonts is deprecated, use ALTERNATIVE_FONTS instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._alternative_fonts into RPRMakie.
│  WARNING: Makie._current_figure is deprecated, use CURRENT_FIGURE instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._current_figure into RPRMakie.
│  WARNING: Makie._default_font is deprecated, use DEFAULT_FONT instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie._default_font into RPRMakie.
│  WARNING: Makie.default_palettes is deprecated, use DEFAULT_PALETTES instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.default_palettes into RPRMakie.
│  WARNING: Makie.minimal_default is deprecated, use MAKIE_DEFAULT_THEME instead.
│    likely near none:1
│  WARNING: importing deprecated binding Makie.minimal_default into RPRMakie.
└
@prbzrg prbzrg added the bug label Jul 18, 2023
@SimonDanisch
Copy link
Member

This should only come up with you explicitly enabling deprecation warnings.
Its currently unavoidable, since we deprecated those and the backend re-export Makie's functions, so they need to import and re-export those bindings, to correctly deprecate them.
We could stop exporting them in #2831 (comment)

@andreasnoack
Copy link

This should only come up with you explicitly enabling deprecation warnings.

But that is pretty common to do on CI because most packages would like to avoid using deprecated functionality. Since this can't be controlled per module, all packages that depend on Makie are currently unable to use the useful CI functionality.

@SimonDanisch
Copy link
Member

Lets remove all deprecation warnings in 0.20

@SimonDanisch SimonDanisch reopened this Sep 8, 2023
@SimonDanisch
Copy link
Member

Closed in #3113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants