Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message for out-of-range color #4047

Closed
fredcallaway opened this issue Jul 22, 2024 · 3 comments
Closed

Bad error message for out-of-range color #4047

fredcallaway opened this issue Jul 22, 2024 · 3 comments
Labels

Comments

@fredcallaway
Copy link

julia> scatter([Point(1,1)], color=1., colorrange=(2., 3.))
ERROR: MethodError: Cannot `convert` an object of type
  Vector{MakieCore.Automatic} to an object of type
  Union{ColorTypes.RGBA{Float32}, Vector{ColorTypes.RGBA{Float32}}}

Seems like a good situation to add an explicit check and useful error. (As a side note, I've found bad error messages to be a common problem with this package)

@jkrumbiegel
Copy link
Member

jkrumbiegel commented Jul 22, 2024

As a side note, I've found bad error messages to be a common problem with this package

Please file as many as you can, this really helps! The only way this gets better is by knocking bad messages out one by one.

This issue should be fixed with #4048

@fredcallaway
Copy link
Author

Please file as many as you can, this really helps!

I'm so glad to hear that the maintainers are interested in improving error message—I'll make sure to file reports whenever I encounter bad ones :)

@jkrumbiegel
Copy link
Member

Fixed by #4048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants