Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name clash in plot! for arrow plots #2738

Closed
steffenhaug opened this issue Mar 9, 2023 · 1 comment · Fixed by #2740
Closed

Name clash in plot! for arrow plots #2738

steffenhaug opened this issue Mar 9, 2023 · 1 comment · Fixed by #2740

Comments

@steffenhaug
Copy link
Contributor

When trying to normalize an arrow plot in Makie version v0.19.2, I get the error

ERROR: MethodError: objects of type Observable{Any} are not callable

Minimal steps to reproduce:

arrows!(ax12, xs´, ys´, u, v;
    normalize=true,
)

Looking at the history, I can see that at some point StaticArrays.normalize was changed to just normalize here:

dir = n ? normalize(dir) : dir

Which now makes the name clash with the name of the parameter.

This looks simple enough to fix, so I could try doing it myself. I'd be happy to contribute but I just started learning Julia two days ago so I might need some help.

@asinghvi17
Copy link
Member

asinghvi17 commented Mar 9, 2023

Yeah, you could definitely make a PR changing normalize to StaticArrays.normalize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants