Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot frames missing #14

Closed
ro-ble opened this issue Mar 27, 2020 · 3 comments · Fixed by #16
Closed

Plot frames missing #14

ro-ble opened this issue Mar 27, 2020 · 3 comments · Fixed by #16

Comments

@ro-ble
Copy link

ro-ble commented Mar 27, 2020

When using your theme package, I noticed that the frame as you can see on the left and bottom of the plot is missing.

image
without frame

image
with frame (like intended)

When searching for the source of this problem I saw that the frames attribute was properly set on the axis2d object. However that did not result in the wanted frame.

I found out, that setting the frames attribute on the axis object instead of the axis2d would produce our frame. Do you know if this would be an AbstractPlotting Error or something to correct in your Package?

following code did the quick fix:

import MakieThemes
const mt = MakieThemes
t = mt.ggthemr(:fresh)
t.axis.frame.frames = t.axis2d.frame.frames
@mkborregaard
Copy link
Collaborator

Yes, this package is not currently fully functional. Aim to make it so soon!

@ro-ble
Copy link
Author

ro-ble commented Mar 28, 2020

I really appreciate your work. If you wish some help with this, you can message me.

@mkborregaard
Copy link
Collaborator

Thanks, very appreciated. I'll be in touch once I get an overview :-)

@asinghvi17 asinghvi17 linked a pull request Feb 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants