Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ruby 2.5.7/2.6.5, see: ManageIQ/manageiq#19414 #16

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Oct 24, 2019

Test ruby 2.5.7/2.6.5, see: ManageIQ/manageiq#19414

@jrafanie jrafanie changed the title Test with ruby 2.5.7 and 2.6.5, see: https://github.com/ManageIQ/managei Test ruby 2.5.7/2.6.5, see: ManageIQ/manageiq#19414 Oct 24, 2019
@miq-bot
Copy link
Member

miq-bot commented Oct 24, 2019

Checked commit jrafanie@45be2f1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit 806ed4b into ManageIQ:master Oct 25, 2019
@Fryguy Fryguy added the test label Oct 25, 2019
@Fryguy Fryguy self-assigned this Oct 25, 2019
@Fryguy
Copy link
Member

Fryguy commented Oct 25, 2019

@carbonin @jrafanie FYI - https://github.com/ManageIQ/container-httpd/blob/master/Dockerfile#L84-L85

EDIT: I just noticed ManageIQ/container-httpd#41 , and didn't realize it was already on the plan.

@Fryguy Fryguy added this to the Sprint 123 Ending Oct 28, 2019 milestone Oct 25, 2019
@jrafanie
Copy link
Member Author

@carbonin @jrafanie FYI - https://github.com/ManageIQ/container-httpd/blob/master/Dockerfile#L84-L85

Ruby 2.5.x should be fine to update in the Dockerfile though right? It looks like it's just the 2.3.1 lines:
https://github.com/ManageIQ/container-httpd/blob/4e6f67f199e87a5c5c96abcfa79cd9ddf641fd7e/Dockerfile#L73-L85

@simaishi @carbonin I also noticed we're building centos 7 upstream even though http://mirror.centos.org/centos/8-stream/BaseOS/x86_64/os/ is out. There's so many references to centos7/epel7 here:

https://github.com/ManageIQ/manageiq-appliance-build/blob/0a0d04bfe53601ade18f08b82c96905e22d709fe/kickstarts/partials/main/repos.ks.erb#L2-L16... some are duplicated in the Dockerfile... will have to discuss with you how we upgrade those.

@jrafanie jrafanie deleted the update_travis_rubies branch October 25, 2019 17:38
@simaishi
Copy link
Contributor

simaishi commented Oct 25, 2019

@simaishi @carbonin I also noticed we're building centos 7 upstream even though http://mirror.centos.org/centos/8-stream/BaseOS/x86_64/os/ is out.

I'm working on CentOS 8 update for appliance right now, but this will take a bit of time as I need to setup a new build machine (which is where I'm at)

@jrafanie
Copy link
Member Author

I'm working on CentOS 8 update for appliance right now, but this will take a bit of time as I need to setup a new build machine (which is where I'm at)

Ok, great! I'm trying jemalloc on epel8 and noticed the os difference in manageiq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants