Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exe/floe return success status if the workflow was successful #129

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Oct 11, 2023

split out of #127

@kbrock kbrock added the enhancement New feature or request label Oct 11, 2023
@miq-bot
Copy link
Member

miq-bot commented Oct 11, 2023

Checked commit kbrock@3342460 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare self-assigned this Oct 11, 2023
@agrare agrare merged commit 3c6f8c4 into ManageIQ:master Oct 11, 2023
5 checks passed
@kbrock kbrock deleted the return_code branch October 11, 2023 13:45
Fryguy added a commit that referenced this pull request Oct 12, 2023
Added:
- For task errors, use the json on the last line (#128)
- Add ability to pass task service account to kube runner (#131)

Fixed:
- Don't put credentials file into input (#124)
- exe/floe return success status if the workflow was successful (#129)
- For error output, drop trailing newline (#126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants