Add ability to pass workflow service account to kube runner #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Fryguy
commented
Oct 12, 2023
| @@ -35,6 +35,8 @@ def initialize(options = {}) | |||
|
|
|||
| @namespace = options.fetch("namespace", "default") | |||
|
|
|||
| @workflow_service_account = options["workflow_service_account"] | |||
There was a problem hiding this comment.
Naming is hard - couldn't figure out a good name here, but if you have other ideas, please mention.
There was a problem hiding this comment.
Agreed on task_service_account, since this is specifically for the tasks that are launched.
Fryguy
force-pushed
the
add_workflow_service_account
branch
from
2b56b1c
to
2ab6189
Compare
2 tasks
|
Checked commits Fryguy/floe@2ab6189~...49ed818 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Fryguy
added a commit
that referenced
this pull request
Oct 12, 2023
Added: - For task errors, use the json on the last line (#128) - Add ability to pass task service account to kube runner (#131) Fixed: - Don't put credentials file into input (#124) - exe/floe return success status if the workflow was successful (#129) - For error output, drop trailing newline (#126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agrare @kbrock Please review
cc @bdunne