Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler State#long_name #204

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Simpler State#long_name #204

merged 1 commit into from
Jun 7, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jun 1, 2024

Since the class name was derived from the type, just use the type variable

(this also makes it easier to output this information if we were logging without the class instantiated)

Logs have the same before/after

@kbrock
Copy link
Member Author

kbrock commented Jun 3, 2024

update:

  • rebase

@kbrock
Copy link
Member Author

kbrock commented Jun 5, 2024

update:

  • rebase

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2024

Checked commit kbrock@ba0680d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare merged commit 09eb908 into ManageIQ:master Jun 7, 2024
5 checks passed
@kbrock kbrock deleted the minor_changes branch June 10, 2024 13:21
agrare added a commit that referenced this pull request Jun 20, 2024
Fixed
- ResultPath=$ replaces complete output (#199)
- Fix retrier backoff values (#200)
- Fix Retry issues (#202)
- Add Apache-2.0 license (#217)

Changed
- Update gemspec summary (#205)
- Simpler State#long_name (#204)
- State only modifies Context#state - prep for Map/Parallel (#206)
- Set StateHistory in Workflow not State (#211)
- Make Runner#wait optional (#190)
- Pass credentials around with context (#203)
- Pass context to State without workflow (#216)
- Move the guts of the CLI into a class for easy testing (#220)

Added
- Set State PreviousStateGuid in StateHistory (#208)
- Add a codeclimate config file (#224)
- Add an Execution unique ID to Context (#226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants