Set `State["PreviousStateGuid"] in StateHistory #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
set_previous_state_guid
branch
from
9b7c8a4
to
1ca465c
Compare
kbrock
approved these changes
Jun 6, 2024
lib/floe/workflow.rb
Outdated
|
|
||
| return unless context.next_state | ||
|
|
||
| next_state = {"Name" => context.next_state, "PreviousStateGuid" => context.state["Guid"]} |
There was a problem hiding this comment.
Nice. Introducing next_state removes that restore_values which was a little confusing.
There was a problem hiding this comment.
Do you want to have Guid a Workflow concept?
diff --git a/lib/floe/workflow.rb b/lib/floe/workflow.rb
index c7d5b37..68ee848 100644
--- a/lib/floe/workflow.rb
+++ b/lib/floe/workflow.rb
@@ -167,2 +167,3 @@ module Floe
context.state["Input"] = context.execution["Input"].dup
+ context.state["Guid"] = SecureRandom.uuid
context.execution["StartTime"] = Time.now.utc.iso8601
@@ -180,3 +181,3 @@ module Floe
def step!
- next_state = {"Name" => context.next_state, "PreviousStateGuid" => context.state["Guid"]}
+ next_state = {"Name" => context.next_state, "Guid" => SecureRandom.uuid, "PreviousStateGuid" => context.state["Guid"]}
diff --git a/lib/floe/workflow/state.rb b/lib/floe/workflow/state.rb
index a44b584..c757f97 100644
--- a/lib/floe/workflow/state.rb
+++ b/lib/floe/workflow/state.rb
@@ -55,3 +55,2 @@ module Floe
def start(_input)
- context.state["Guid"] = SecureRandom.uuid
context.state["EnteredTime"] = Time.now.utc.iso8601
kbrock
added
enhancement
|
This will work great after #211 |
agrare
force-pushed
the
set_previous_state_guid
branch
from
1ca465c
to
eeb0592
Compare
agrare
force-pushed
the
set_previous_state_guid
branch
from
7d16a4b
to
d603530
Compare
agrare
changed the title
agrare
force-pushed
the
set_previous_state_guid
branch
from
d603530
to
03140e1
Compare
|
Checked commits agrare/floe@ab26e1d~...03140e1 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
added a commit
that referenced
this pull request
Jun 20, 2024
Fixed - ResultPath=$ replaces complete output (#199) - Fix retrier backoff values (#200) - Fix Retry issues (#202) - Add Apache-2.0 license (#217) Changed - Update gemspec summary (#205) - Simpler State#long_name (#204) - State only modifies Context#state - prep for Map/Parallel (#206) - Set StateHistory in Workflow not State (#211) - Make Runner#wait optional (#190) - Pass credentials around with context (#203) - Pass context to State without workflow (#216) - Move the guts of the CLI into a class for easy testing (#220) Added - Set State PreviousStateGuid in StateHistory (#208) - Add a codeclimate config file (#224) - Add an Execution unique ID to Context (#226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the state history more obvious by including the exact previous state Guid in the StateHistory