Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cloud snapshot collector, list page, create & delete methods #1205

Conversation

TonySchneider
Copy link
Member

@TonySchneider TonySchneider commented Feb 22, 2023

We have developed an integration with a new resource type - "cloud volume snapshot" on the Autosde side. Now, we can provide a list of snapshots from the attached physical storage, create a new one based on a particular volume object and delete it - by using the Autosde rest endpoint (The Autosde GEM is already updated with these new features).
Following these new features, I have added to our (MIQ Autosde provider) collector and refresher to pull snapshots from Autosde and show them in the right place - Cloud Volume Snapshots. I also added the counter component to the provider dashboard.

List page:
image

Snapshot summary page:
image

Dashboard:
image

Create snapshot from cloud volume:
1.
image
2.
image

Delete button exists as well at the snapshots page

related PRs:

@miq-bot miq-bot added the wip label Feb 22, 2023
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 84d116c to 9af010f Compare February 22, 2023 20:28
@TonySchneider TonySchneider changed the title [wip] Implement cloud snapshot collector, list page & dashboard counter Implement cloud snapshot collector, list page, create & delete methods Feb 22, 2023
@miq-bot miq-bot removed the wip label Feb 22, 2023
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 9af010f to 0d88fbf Compare February 22, 2023 23:03
@TonySchneider
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 22, 2023
@agrare
Copy link
Member

agrare commented Mar 9, 2023

@TonySchneider hey so maybe I'm missing it, but how is the snapshot being created? Is it over the API through the cloud_volume#snapshot_create action or via cloud_volume_snapshot#create? Or is it not over the API at all and being done in the UI controller?

@TonySchneider
Copy link
Member Author

Hi @agrare , I have used the existing API - cloud_volume#snapshot_create since we need an existing volume for this method so when you want to create a snapshot for a specific volume, you should do this through the cloud volume page

@agrare agrare closed this Mar 15, 2023
@agrare agrare reopened this Mar 15, 2023
@agrare
Copy link
Member

agrare commented Mar 15, 2023

@TonySchneider please resolve the api.yaml failing spec https://github.com/ManageIQ/manageiq-api/actions/runs/4428242306/jobs/7767029454#step:7:104

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 740e88c to d30c300 Compare March 22, 2023 13:58
@TonySchneider
Copy link
Member Author

@agrare fixed

config/api.yml Show resolved Hide resolved
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from d30c300 to 1cc5f39 Compare March 23, 2023 13:27
@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2023

Checked commits Autosde/manageiq-api@0d88fbf~...1cc5f39 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@agrare
Copy link
Member

agrare commented Mar 23, 2023

@TonySchneider can you add tests covering these new APIs to the spec/requests/cloud_volume_snapshots_spec.rb spec?

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 1cc5f39 to 3ae2239 Compare April 2, 2023 12:45
@TonySchneider
Copy link
Member Author

aligned the branch with the master, will add the tests to spec/requests/cloud_volume_snapshots_spec.rb

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 93e0481 to 5409e74 Compare April 4, 2023 13:09
@agrare agrare merged commit f7affb8 into ManageIQ:master Apr 4, 2023
4 checks passed
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet

4 participants