-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cloud snapshot collector, list page, create & delete methods #8647
Implement cloud snapshot collector, list page, create & delete methods #8647
Conversation
0a71232
to
b0d6d03
Compare
b0d6d03
to
a135c13
Compare
From Pull Request: ManageIQ/manageiq-ui-classic#8647
@ManageIQ/committers-ui Hey guys, any updates? |
@TonySchneider |
2761325
to
c6d2f48
Compare
aligned the branch with the master, will look at the falling tests |
@miq-bot cross-repo-tests ManageIQ/manageiq-api#1205, ManageIQ/manageiq-providers-autosde#210 |
From Pull Request: ManageIQ/manageiq-ui-classic#8647
c2ee581
to
c5d201b
Compare
Hey @TonySchneider, could you please have a look into failing specs here. |
e375557
to
d361137
Compare
@jeffibm can someone please review this one, tests have passed |
Hey @TonySchneider , could you rebase your branch with master please.. |
d361137
to
3aa3718
Compare
@jeffibm done |
will merge once the failing GitHub actions are fixed (due to some other reasons). |
3aa3718
to
9153bbe
Compare
Hey @TonySchneider , could you please rebase with master |
It is up to date @jeffibm |
most of our recent failing specs were getting resolved after a rebase with the master... |
…ate & delete methods
c58cd85
to
7f4d41c
Compare
Checked commit Autosde@7f4d41c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/helpers/application_helper/toolbar/cloud_volume_snapshots_center.rb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @agrare , specs are now ok. shall we merge?
We have developed an integration with a new resource type - "cloud volume snapshot" on the Autosde side. Now, we can provide a list of snapshots from the attached physical storage, create a new one based on a particular volume object and delete it - by using the Autosde rest endpoint (The Autosde GEM is already updated with these new features).
Following these new features, I have added to our (MIQ Autosde provider) collector and refresher to pull snapshots from Autosde and show them in the right place - Cloud Volume Snapshots. I also added the counter component to the provider dashboard.
List page:
Snapshot summary page:
Dashboard:
Create snapshot from cloud volume:
1.
2.
Delete button exists as well at the snapshots page
related PRs: