Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cloud snapshot collector, list page, create & delete methods #8647

Conversation

TonySchneider
Copy link
Member

@TonySchneider TonySchneider commented Feb 14, 2023

We have developed an integration with a new resource type - "cloud volume snapshot" on the Autosde side. Now, we can provide a list of snapshots from the attached physical storage, create a new one based on a particular volume object and delete it - by using the Autosde rest endpoint (The Autosde GEM is already updated with these new features).
Following these new features, I have added to our (MIQ Autosde provider) collector and refresher to pull snapshots from Autosde and show them in the right place - Cloud Volume Snapshots. I also added the counter component to the provider dashboard.

List page:
image

Snapshot summary page:
image

Dashboard:
image

Create snapshot from cloud volume:
1.
image
2.
image

Delete button exists as well at the snapshots page

related PRs:

@TonySchneider TonySchneider requested a review from a team as a code owner February 14, 2023 21:51
@TonySchneider TonySchneider changed the title Implement cloud snapshot collector, list page & dashboard counter [wip] Implement cloud snapshot collector, list page & dashboard counter Feb 14, 2023
@miq-bot miq-bot added the wip label Feb 14, 2023
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 0a71232 to b0d6d03 Compare February 22, 2023 20:24
@TonySchneider TonySchneider changed the title [wip] Implement cloud snapshot collector, list page & dashboard counter Implement cloud snapshot collector, list page, create & delete methods Feb 22, 2023
@miq-bot miq-bot removed the wip label Feb 22, 2023
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from b0d6d03 to a135c13 Compare February 22, 2023 23:02
@TonySchneider
Copy link
Member Author

@TonySchneider
Copy link
Member Author

@ManageIQ/committers-ui Hey guys, any updates?

@agrare
Copy link
Member

agrare commented Mar 23, 2023

@TonySchneider spec:jest is failing

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 2761325 to c6d2f48 Compare April 2, 2023 12:47
@TonySchneider
Copy link
Member Author

aligned the branch with the master, will look at the falling tests

@TonySchneider
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Apr 2, 2023
@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from c2ee581 to c5d201b Compare April 4, 2023 13:20
@jeffibm
Copy link
Member

jeffibm commented Apr 5, 2023

Hey @TonySchneider, could you please have a look into failing specs here.

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from e375557 to d361137 Compare April 5, 2023 12:19
@TonySchneider
Copy link
Member Author

@jeffibm can someone please review this one, tests have passed

@jeffibm
Copy link
Member

jeffibm commented Apr 24, 2023

Hey @TonySchneider , could you rebase your branch with master please..

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from d361137 to 3aa3718 Compare April 24, 2023 12:48
@TonySchneider
Copy link
Member Author

@jeffibm done

@jeffibm
Copy link
Member

jeffibm commented Apr 25, 2023

will merge once the failing GitHub actions are fixed (due to some other reasons).

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from 3aa3718 to 9153bbe Compare April 30, 2023 08:43
@jeffibm
Copy link
Member

jeffibm commented May 2, 2023

Hey @TonySchneider , could you please rebase with master

@TonySchneider
Copy link
Member Author

It is up to date @jeffibm

@jeffibm
Copy link
Member

jeffibm commented May 2, 2023

most of our recent failing specs were getting resolved after a rebase with the master...

@TonySchneider TonySchneider force-pushed the implement-cloud_snapshot-collector_list_page_and_dashboard branch from c58cd85 to 7f4d41c Compare May 2, 2023 09:32
@miq-bot
Copy link
Member

miq-bot commented May 2, 2023

Checked commit Autosde@7f4d41c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
4 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/cloud_volume_snapshots_center.rb

Copy link
Member

@jeffibm jeffibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @agrare , specs are now ok. shall we merge?

@jeffibm jeffibm merged commit fb2068c into ManageIQ:master May 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants