Implement cloud snapshot collector, list page, create & delete methods #22359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonySchneider
requested review from
agrare,
Fryguy and
kbrock
as code owners
TonySchneider
changed the title
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Feb 22, 2023
From Pull Request: ManageIQ/manageiq#22359
TonySchneider
changed the title
…ate & delete methods create & delete methods
TonySchneider
force-pushed
the
implement-cloud_snapshot-collector_list_page_and_dashboard
branch
from
7c71c41
to
b42a4af
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Feb 22, 2023
From Pull Request: ManageIQ/manageiq#22359
agrare
reviewed
Mar 9, 2023
app/models/ext_management_system.rb
Outdated
| @@ -302,6 +303,8 @@ def validate_zone_not_maintenance_when_ems_enabled? | |||
| supports_attribute :feature => :cloud_subnet_create | |||
| supports_attribute :feature => :cloud_volume | |||
| supports_attribute :feature => :cloud_volume_create | |||
| supports_attribute :feature => :cloud_volume_snapshots | |||
| supports_attribute :feature => :cloud_volume_snapshots_create | |||
There was a problem hiding this comment.
Do we need cloud_volume_snapshots_create on the EMS? I'd think that we would check for an EMS that supports cloud_volume_snapshots, then go to the cloud_volume_snapshot class to check if it supports create
There was a problem hiding this comment.
Yeah, actually we don't need it since the creation method is implemented in CloudVolume class. removing...
agrare
reviewed
Mar 13, 2023
app/models/ext_management_system.rb
Outdated
| @@ -154,6 +154,7 @@ def self.create_from_params(params, endpoints, authentications) | |||
| supports_not :cloud_subnet_create | |||
| supports_not :cloud_tenant_mapping | |||
| supports_not :cloud_volume_create | |||
| supports_not :cloud_volume_snapshots_create | |||
There was a problem hiding this comment.
I think we also wouldn't need this one then?
TonySchneider
force-pushed
the
implement-cloud_snapshot-collector_list_page_and_dashboard
branch
from
d56dfcd
to
7e0a0e6
Compare
|
Checked commits Autosde/manageiq@b42a4af~...7e0a0e6 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have developed an integration with a new resource type - "cloud volume snapshot" on the Autosde side. Now, we can provide a list of snapshots from the attached physical storage, create a new one based on a particular volume object and delete it - by using the Autosde rest endpoint (The Autosde GEM is already updated with these new features).
Following these new features, I have added to our (MIQ Autosde provider) collector and refresher to pull snapshots from Autosde and show them in the right place - Cloud Volume Snapshots. I also added the counter component to the provider dashboard.
List page:
Snapshot summary page:
Dashboard:
Create snapshot from cloud volume:
1.
2.
Delete button exists as well at the snapshots page
related PRs: