Update Resource Pool API to include type attribute

[Guddetisandeep]

Dependent PR for enabling Resource Pool feature under Clouds section(Compute > Clouds > Resource Pools)

• manageiq Core changes
  Update Resource Pool Identifiers and UI for Cloud and Infrastructure Categorization manageiq#22879

• manageiq-ui-classic changes
  [WIP] Add Resource_pool UI for Cloud managers manageiq-ui-classic#8929

• manageiq-schema changes
  Update resource pool feature identifiers to infrastructure-specific manageiq-schema#718

• manageiq-api changes
  Update Resource Pool API to include type attribute #1248

[Guddetisandeep]

The query returns only the resource pools associated with cloud management when the type attribute is used with the specified class (ManageIQ::Providers::CloudManager::ResourcePool)

curl -s -X GET -H "X-Auth-Token: $(miq_auth_token)" -H "Accept: application/json" "http://localhost:3000/api/resource_pools?type=ManageIQ::Providers::CloudManager::ResourcePool" | jq .
{
  "name": "resource_pools",
  "count": 142,
  "subcount": 1,
  "subquery_count": 1,
  "pages": 1,
  "resources": [
    {
      "href": "http://localhost:3000/api/resource_pools/162"
    }
  ],
  "actions": [
    {
      "name": "query",
      "method": "post",
      "href": "http://localhost:3000/api/resource_pools"
    }
  ],
  "links": {
    "self": "http://localhost:3000/api/resource_pools?type=ManageIQ::Providers::CloudManager::ResourcePool&offset=0",
    "first": "http://localhost:3000/api/resource_pools?type=ManageIQ::Providers::CloudManager::ResourcePool&offset=0",
    "last": "http://localhost:3000/api/resource_pools?type=ManageIQ::Providers::CloudManager::ResourcePool&offset=0"
  }
}

[miq-bot]

Checked commit Guddetisandeep@c7e65fe with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 1 offense detected

app/controllers/api/resource_pools_controller.rb

• ❗ - Line 23, Col 46 - Style/ClassCheck - Prefer Object#kind_of? over Object#is_a?.

[Fryguy]

@Guddetisandeep - We found there's a better way to do this than using a type filter. Instead, the caller can pass a collection_class parameter at the same level as the filter. See #1256

[Fryguy]

I think we can close this PR, and the callers can use collection_class instead, which should already work for ResourcePools.

[Guddetisandeep]

Closing this PR using collection_class instead of the type filter.