Update resource pool feature identifiers to infrastructure-specific #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2024
Guddetisandeep
force-pushed
the
update_resource_pool_identifiers
branch
from
a312313
to
f52eb46
Compare
agrare
reviewed
May 16, 2024
Comment on lines
16
to
14
| FEATURE_MAPPING_CREATE = { | ||
| "resource_pool_infra" => {:name => "Infrastructure Resource Pools", :description => "Access Everything under Infrastructure Resource Pools", :feature_type => "node"}, | ||
| "resource_pool_infra_view" => {:name => "View", :description => "Display Lists of Infrastructure Resource Pools", :feature_type => "view", :parent => "resource_pool_infra"}, | ||
| "resource_pool_infra_show_list" => {:name => "List", :description => "Display Lists of Infrastructure Resource Pools", :feature_type => "view", :parent => "resource_pool_infra_view"}, | ||
| "resource_pool_infra_show" => {:name => "Show", :description => "Display Individual Infrastructure Resource Pools", :feature_type => "view", :parent => "resource_pool_infra_view"}, | ||
| "resource_pool_infra_control" => {:name => "Operate", :description => "Perform Operations on Infrastructure Resource Pools", :feature_type => "control", :parent => "resource_pool_infra"}, | ||
| "resource_pool_infra_tag" => {:name => "Edit Tags", :description => "Edit Tags of Infrastructure Resource Pools", :feature_type => "control", :parent => "resource_pool_infra_control"}, | ||
| "resource_pool_infra_protect" => {:name => "Manage Policies", :description => "Manage Policies of Infrastructure Resource Pools", :feature_type => "control", :parent => "resource_pool_infra_control"}, | ||
| "resource_pool_infra_admin" => {:name => "Modify", :description => "Modify Infrastructure Resource Pools", :feature_type => "admin", :parent => "resource_pool_infra"}, | ||
| "resource_pool_infra_delete" => {:name => "Remove", :description => "Remove Infrastructure Resource Pools", :feature_type => "admin", :parent => "resource_pool_infra_admin"} | ||
| }.freeze |
There was a problem hiding this comment.
@Guddetisandeep you don't need to create the new features in this PR, that will be done when we seed the database. The only reason we need schema migration for existing product features is because users might have used the existing records for user/group permissions already and we can't just delete them.
agrare
reviewed
May 16, 2024
Comment on lines
4
to
14
| FEATURE_MAPPING_UPDATE = { | ||
| 'resource_pool' => 'resource_pool_cloud', | ||
| 'resource_pool_view' => 'resource_pool_cloud_view', | ||
| 'resource_pool_show_list' => 'resource_pool_cloud_show_list', | ||
| 'resource_pool_show' => 'resource_pool_cloud_show', | ||
| 'resource_pool_control' => 'resource_pool_cloud_control', | ||
| 'resource_pool_tag' => 'resource_pool_cloud_tag', | ||
| 'resource_pool_protect' => 'resource_pool_cloud_protect', | ||
| 'resource_pool_admin' => 'resource_pool_cloud_admin', | ||
| 'resource_pool_delete' => 'resource_pool_cloud_delete' | ||
| }.freeze |
There was a problem hiding this comment.
@Guddetisandeep since the existing product feature was for infrastructure providers we should update the existing records to _infra not _cloud
Guddetisandeep
force-pushed
the
update_resource_pool_identifiers
branch
from
f52eb46
to
81dcc8b
Compare
|
Checked commit Guddetisandeep@81dcc8b with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PR for enabling Resource Pool feature under Clouds section(Compute > Clouds > Resource Pools)
manageiq Core changes
Update Resource Pool Identifiers and UI for Cloud and Infrastructure Categorization manageiq#22879
manageiq-ui-classic changes
[WIP] Add Resource_pool UI for Cloud managers manageiq-ui-classic#8929
manageiq-schema changes
Update resource pool feature identifiers to infrastructure-specific #718
manageiq-api changes
Update Resource Pool API to include type attribute manageiq-api#1248