Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rails 6.1 #186

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Upgrade to rails 6.1 #186

merged 1 commit into from
Aug 12, 2022

Conversation

jrafanie
Copy link
Member

@Fryguy
Copy link
Member

Fryguy commented Aug 12, 2022

I still don't have GitHub Actions working here properly - can you run the specs manually locally?

@miq-bot
Copy link
Member

miq-bot commented Aug 12, 2022

Checked commit jrafanie@5713b18 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@jrafanie
Copy link
Member Author

I've manually run the tests and the only failures on mac, also fail on rails 6.0.

Failed examples:

rspec ./spec/cli_spec.rb:736 # ManageIQ::ApplianceConsole::Cli#set_replication should configure DDBB replication as standby when the required parameters are specified
rspec ./spec/cli_spec.rb:727 # ManageIQ::ApplianceConsole::Cli#set_replication should configure primary replication with a fixed database name and user when specified in the flags
rspec ./spec/cli_spec.rb:747 # ManageIQ::ApplianceConsole::Cli#set_replication should configure repmgrd when auto-failover flag is set
rspec ./spec/cli_spec.rb:718 # ManageIQ::ApplianceConsole::Cli#set_replication should configure DB as primary when the required arguments are specified

@Fryguy Fryguy merged commit 741f2b6 into ManageIQ:master Aug 12, 2022
@Fryguy Fryguy self-assigned this Aug 12, 2022
@jrafanie jrafanie deleted the move_to_rails_6_1 branch August 12, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants