6.1 configurations has symbol keys, [] deprecated, use configs_for #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ManageIQ/manageiq-appliance#366 DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for) This fixes the deprecation This now uses symbols for configuration keys (since rails 6.1 has changed this as well) Similar to: ManageIQ/manageiq@0d57f5e
jrafanie
force-pushed
the
fix_rails61_db_connections_check
branch
from
bc84a3a
to
b061ffa
Compare
|
cc @kbrock |
|
I'm guessing we'll need a new release of this so we can use it going forward |
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Sep 2, 2022
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ManageIQ/manageiq-appliance#366
DEPRECATION WARNING: [] is deprecated and will be removed from Rails 6.2 (Use configs_for)
This fixes the deprecation
This now uses symbols for configuration keys (since rails 6.1 has changed this as well)
Similar to: ManageIQ/manageiq@0d57f5e