Update to Highline 2.1.0 #201
Conversation
kbrock
force-pushed
the
highline
branch
2 times, most recently
from
114b808
to
f33cbff
Compare
|
update:
I tested on a nightly appliance. had to muck with the appliance console gemspec in 2 places and the vmdb/gemfile.lock, but I was able to setup dhcp, create a v2 key, set the region and configure an internal database. |
|
@bdunne let me know if you are happy with these changes. |
|
@kbrock Can you run the full rspec suite locally? We still don't have github actions working in this repository yet. |
|
Bouncing now that GitHub Actions is in place - 3.0 should still fail cause of kwargs at the moment |
|
Oh nice! This seems to fix the pending I put in spec/database_admin_spec.rb. Can you remove that pending in this PR @kbrock ? |
The questions asked and the output are merged together. This method was only used in one spot so not much lost.
If we enter a value that is not a default value, but one is derived, then the actual value entered is output. so if we type in text that infers option 1, then highline now outputs (1) Not exactly sure why there is a change for a default value being presented, I'm guessing the value was not checked by the previous test. So the change in expect_heard shows this at this time
This is replaced by HighLine.default_instance
this was necessary to get older version of highline up and running in rails see ManageIQ#178 df5cffb
|
update:
|
|
Checked commits kbrock/manageiq-appliance_console@5db7c89~...ff01d19 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Love that you could kill the tty hack too |
Fixed - Fix sporadic test failure [#204] - Remove MIQ specific gem source [#209] - Double escape @ in realm to avoid shell interpretation [#211] - Move gem name loader to proper namespaced location [#208] - Separate kerberos from service principal name and use correctly [#215] - Add manageiq user to allowed_uids for sssd [#220] - Remove warning about using pg_dump [#221] - Fix specs where AwesomeSpawn private interface changed [#224] - Change the Name of the CA from something to ApplianceCA [#228] - Fix YAML.load_file failing on aliases [#234] Added - Make backward compatible changes to work with repmgr13 - version 5.2.1 [#192] - Support Ruby 3.0 [#206] - Support Ruby 3.1 [#227] - Allow rails 7 gems in gemspec [#226] Changed - Update to Highline 2.1.0 [#201] - Clean up test output (highline and stdout messages) [#210] Removed - Drop Ruby 2.7 [#223]
steal anything you want out of here @bdunne
not thrilled with the changes to tests with the expect heard stuff.
wish the questions were not going through, but this is the least invasive way I could think to solve
overlaps with #200
Fixes #181