Fix ruby 2.7 failures #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5032
💛 - Coveralls |
|
@miq-bot cross-repo-test #471 including ManageIQ/manageiq#21023 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Feb 9, 2021
From Pull Request: ManageIQ/manageiq-automation_engine#471
18 tasks
I believe this commit causes the previous \t to be skipped in ruby 2.7: ruby/ruby@c6fb7c1 Part of ManageIQ/manageiq#19678
Fixes an issue where 'unhandled exception' messages sent to STDERR are lost over drb with automate:
```
expected: ("Method STDERR: /my/automate/method:2:in `my_method': unhandled exception")
got: ("<AEMethod /my/automate/method> The following error occurred during method evaluation:") (1 time)
("<AEMethod /my/automate/method> RuntimeError: ") (1 time)
("<AEMethod /my/automate/method> /my/automate/method:2:in `my_method'") (1 time)
```
Part of ManageIQ/manageiq#19678
jrafanie
force-pushed
the
fix_ruby_2_7_failures
branch
from
1797b25
to
c9495a6
Compare
|
Checked commits jrafanie/manageiq-automation_engine@05309d2~...c9495a6 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was tested as part of a cross repo, here along with a core change to allow ruby 2.7.
Part of ManageIQ/manageiq#19678