Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby 2.7 in the Gemfile #21023

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Support ruby 2.7 in the Gemfile #21023

merged 1 commit into from
Feb 10, 2021

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Feb 8, 2021

Part of #19678

@jrafanie
Copy link
Member Author

jrafanie commented Feb 8, 2021

@miq-bot cross-repo-test /all, ManageIQ/manageiq-automation_engine#471

@jrafanie
Copy link
Member Author

jrafanie commented Feb 9, 2021

@jrafanie
Copy link
Member Author

jrafanie commented Feb 9, 2021

@miq-bot cross-repo-test /all, including ManageIQ/manageiq-automation_engine#471, #21023

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 9, 2021
@jrafanie jrafanie changed the title [WIP] Support ruby 2.7 Support ruby 2.7 in the Gemfile Feb 9, 2021
@jrafanie jrafanie added ruby2.7 and removed wip labels Feb 9, 2021
@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2021

Checked commit jrafanie@06b669a with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@jrafanie jrafanie mentioned this pull request Feb 9, 2021
18 tasks
@jrafanie
Copy link
Member Author

jrafanie commented Feb 9, 2021

This PR is ready to go. It doesn't impose ruby 2.7 on travis, only allows it to be run locally.
Once ManageIQ/manageiq-automation_engine#471 is merged, we are safe to use 2.7 everywhere.
We'll force ruby 2.7 on travis and master after we branch.

@Fryguy Fryguy merged commit 71d8870 into ManageIQ:master Feb 10, 2021
@Fryguy Fryguy self-assigned this Feb 10, 2021
@jrafanie jrafanie deleted the ruby27 branch February 10, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants