Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in the manageiq.* automate and vmdb roles #254

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

syncrou
Copy link
Contributor

@syncrou syncrou commented Mar 1, 2018

The roles have been namespaced via the manageiq prefix: manageiq.manageiq-automate and manageiq.manageiq-vmdb.

https://bugzilla.redhat.com/show_bug.cgi?id=1539762

Edit by @NickLaMuro : Updated the description and title to reflect the actual prefix that was commited per this comment: #254 (comment)

@syncrou
Copy link
Contributor Author

syncrou commented Mar 1, 2018

@miq-bot add_label wip, enhancement

@miq-bot assign @Fryguy

cc - @gmcculloug, @gtanzillo

@miq-bot miq-bot changed the title Add in the miq. automate and vmdb roles [WIP] Add in the miq. automate and vmdb roles Mar 1, 2018
@syncrou
Copy link
Contributor Author

syncrou commented Mar 6, 2018

@miq-bot remove_label wip

@miq-bot miq-bot changed the title [WIP] Add in the miq. automate and vmdb roles Add in the miq. automate and vmdb roles Mar 6, 2018
@miq-bot miq-bot removed the wip label Mar 6, 2018
@syncrou syncrou force-pushed the seed_ansible_playbooks branch 2 times, most recently from cb9d1c3 to cb9277c Compare March 6, 2018 22:35
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Mar 21, 2018
TODO: Write tests, ruggedize this, make sure role activation run this
and make sure it works 😅

All of this depends on:
https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096
ManageIQ/manageiq-content#254
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Mar 22, 2018
TODO: Write tests, ruggedize this, make sure role activation run this
and make sure it works 😅

All of this depends on:
https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096
ManageIQ/manageiq-content#254
@gmcculloug
Copy link
Member

@Fryguy I think this is ready to merge. Any remaining issues?

jrafanie added a commit to jrafanie/manageiq that referenced this pull request Mar 22, 2018
TODO: Write tests, ruggedize this, make sure role activation run this
and make sure it works 😅

All of this depends on:
https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096
ManageIQ/manageiq-content#254
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Mar 22, 2018
TODO: Write tests, ruggedize this, make sure role activation run this
and make sure it works 😅

All of this depends on:
https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096
ManageIQ/manageiq-content#254
jrafanie added a commit to jrafanie/manageiq that referenced this pull request Mar 22, 2018
TODO: Write tests, add RFE/BZ links when tests are written

All of this depends on:
https://github.com/ManageIQ/ManageIQ/manageiq/pull/17096
ManageIQ/manageiq-content#254
@JPrause
Copy link
Member

JPrause commented Apr 3, 2018

@Fryguy it appears this can be merged. Can you review.

@jrafanie
Copy link
Member

jrafanie commented Apr 9, 2018

@gmcculloug @syncrou can you drop the WIP from the description of this PR if it's ready?

@syncrou
Copy link
Contributor Author

syncrou commented Apr 9, 2018

@jrafanie - I pulled out the WIP statement.

@jrafanie
Copy link
Member

jrafanie commented Apr 9, 2018

@miq-bot add_label blocker

@Fryguy
Copy link
Member

Fryguy commented Apr 10, 2018

Looks good. Since we are adding a lot of yaml here, it might be good to add the yamllint stuff so that the bot can verify it for us. This way, you don't get churn on your yamls, but I'll leave it up to @gmcculloug on how to proceed, since I know you want this is sooner than later.

@gmcculloug
Copy link
Member

@Fryguy Can you point to an example of what is required for yamllint? Depending on the level of effort it could be a follow PR.

@JPrause
Copy link
Member

JPrause commented Apr 10, 2018

@syncrou can you add the garpindashvili/yes label.

@syncrou
Copy link
Contributor Author

syncrou commented Apr 10, 2018

@miq-bot add_label garpindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2018

@syncrou Cannot apply the following label because they are not recognized: garpindashvili/yes

@Fryguy
Copy link
Member

Fryguy commented Apr 10, 2018

@imtayadeway Can you comment on #254 (comment) ?

@Fryguy
Copy link
Member

Fryguy commented Apr 10, 2018

Depending on the level of effort it could be a follow PR.

@gmcculloug Yes, it can be follow up PR. I'm mostly concerned about the churn, which can be distracting in the future, but it's up to you.

@imtayadeway
Copy link
Contributor

@gmcculloug I attempted to answer your question in the form of a PR: #277

@syncrou syncrou closed this Apr 11, 2018
@syncrou syncrou reopened this Apr 11, 2018
@syncrou
Copy link
Contributor Author

syncrou commented Apr 11, 2018

@Fryguy - Everything we discussed for this PR is taken care of.

@Fryguy
Copy link
Member

Fryguy commented Apr 11, 2018

The bot hasn't rerun on this repo, so it hasn't really used the yamllint stuff. The only way to force it is to push a commit (just amend the commit and force push).

@syncrou syncrou force-pushed the seed_ansible_playbooks branch 2 times, most recently from 6ac8e27 to 01cc960 Compare April 11, 2018 20:23
@miq-bot
Copy link
Member

miq-bot commented Apr 11, 2018

Checked commit syncrou@d6fd182 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@syncrou
Copy link
Contributor Author

syncrou commented Apr 12, 2018

@Fryguy - Made a couple of changes suggested by the new yamllint rules. Everything is green now again.

@Fryguy Fryguy merged commit e045e8c into ManageIQ:master Apr 12, 2018
@Fryguy Fryguy added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 12, 2018
simaishi pushed a commit that referenced this pull request Apr 12, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3bc2d372216956eea3ff4f3b2584a8f3de4d31b8
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Apr 12 11:28:35 2018 -0400

    Merge pull request #254 from syncrou/seed_ansible_playbooks
    
    Add in the miq. automate and vmdb roles
    (cherry picked from commit e045e8c31a30cee9c3f455da7f9221e7f30a504b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1566658

@NickLaMuro NickLaMuro changed the title Add in the miq. automate and vmdb roles Add in the manageiq. automate and vmdb roles Feb 15, 2020
@NickLaMuro NickLaMuro changed the title Add in the manageiq. automate and vmdb roles Add in the manageiq.* automate and vmdb roles Feb 15, 2020
@NickLaMuro
Copy link
Member

Note: Updated the PR title and description to match the changes that were made and mentioned in these comments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants