Added Embedded Ansible Content plugin #17096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement @miq-bot assign @gmcculloug cc- @gtanzillo @Fryguy |
gmcculloug
reviewed
Mar 6, 2018
lib/vmdb/plugins.rb
Outdated
| @registered_automate_domains << AutomateDomain.new(domain_directory) | ||
| end | ||
| end | ||
|
|
||
| def register_embedded_ansible_content(engine) | ||
| registered_content_directories(engine, "ansible") do |domain_directory| |
There was a problem hiding this comment.
The domain_directory is a carry-over from the automate method. Suggest content_directory for this one.
syncrou
force-pushed
the
add_embedded_ansible_content_plugin
branch
from
6324dd3
to
360a4f4
Compare
|
I prefer |
syncrou
force-pushed
the
add_embedded_ansible_content_plugin
branch
from
360a4f4
to
4c1d80c
Compare
|
I changed everything to |
|
Checked commit syncrou@4c1d80c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Mar 7, 2018
|
@miq-bot add_label blocker |
simaishi
pushed a commit
that referenced
this pull request
Apr 12, 2018
…lugin Added Embedded Ansible Content plugin (cherry picked from commit 35f2f4e) https://bugzilla.redhat.com/show_bug.cgi?id=1566658
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Vmdb plugin for
AnsibleContent.The registered plugin contains the following paths:
@pathand@roles_pathDependent on: ManageIQ/manageiq-content#254
Thanks to @gmcculloug for helping with the refactor of the Automate and EmbeddedAnsible registration methods
https://bugzilla.redhat.com/show_bug.cgi?id=1539762