Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2V] Remove VMTransform and VMCheckTransformed states #569

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2019

The state machine is being ported to InfraConversionJob.
This PR is the counterpart of ManageIQ/manageiq#19222.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1746592
Depends on ManageIQ/manageiq#19222
Built on #568

@ghost
Copy link
Author

ghost commented Aug 28, 2019

@miq-bot add-label transformation, refactoring, ivanchuk/yes
@miq-bot add-reviewer @gmcculloug
@miq-bot add-reviewer @tinaafitz

@coveralls
Copy link

coveralls commented Aug 28, 2019

Pull Request Test Coverage Report for Build 3512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.88%

Totals Coverage Status
Change from base Build 3511: -0.02%
Covered Lines: 2919
Relevant Lines: 3013

💛 - Coveralls

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2019

Checked commits fabiendupont/manageiq-content@c422313~...3080dda with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@ghost ghost mentioned this pull request Aug 30, 2019
@gmcculloug gmcculloug self-assigned this Sep 2, 2019
@gmcculloug gmcculloug merged commit 3b0e6b2 into ManageIQ:master Sep 2, 2019
@gmcculloug gmcculloug added this to the Sprint 119 Ending Sep 2, 2019 milestone Sep 2, 2019
simaishi pushed a commit that referenced this pull request Oct 31, 2019
…rm_vm

[V2V] Remove VMTransform and VMCheckTransformed states

(cherry picked from commit 3b0e6b2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767542
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit 35cf51360efe3659a142dc124866cc099487e8dc
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Sep 2 12:17:29 2019 -0400

    Merge pull request #569 from fdupont-redhat/v2v_state_machine_transform_vm
    
    [V2V] Remove VMTransform and VMCheckTransformed states
    
    (cherry picked from commit 3b0e6b2fd0176e894d07df24b95203f696b65f32)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767542

@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2019

The backport reverted

commit 1c76cd29d3f46017ef62310a654673b4a2cdaae0
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Dec 3 11:12:42 2019 -0500

    Revert "Merge pull request #569 from fdupont-redhat/v2v_state_machine_transform_vm"

    This reverts commit 35cf51360efe3659a142dc124866cc099487e8dc.

    https://bugzilla.redhat.com/show_bug.cgi?id=1767542

simaishi pushed a commit that referenced this pull request Feb 21, 2020
…rm_vm

[V2V] Remove VMTransform and VMCheckTransformed states

(cherry picked from commit 3b0e6b2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767542
@simaishi
Copy link
Contributor

Ivanchuk backport details:

$ git log -1
commit ee6ec2c0b95336d55abcba89ef4827459151f879
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Sep 2 12:17:29 2019 -0400

    Merge pull request #569 from fdupont-redhat/v2v_state_machine_transform_vm

    [V2V] Remove VMTransform and VMCheckTransformed states

    (cherry picked from commit 3b0e6b2fd0176e894d07df24b95203f696b65f32)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants