Add missing dependency on net-scp, consolidate gem loader to the namespaced location #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/ManageIQ/manageiq-providers-amazon/blob/a22095fd65085a052202ce707aea69839550ed87/app/models/manageiq/providers/amazon/agent_coordinator.rb#L3 ManageIQ::ApplianceConsole was pulling in this dependency for us but if zeitwerk autoloads this provider first, the gem dependency doesn't exist yet. See: https://github.com/ManageIQ/manageiq-appliance_console/blob/master/manageiq-appliance_console.gemspec#L32
Closed
55 tasks
|
Checked commits jrafanie/manageiq-providers-amazon@b5e2fc8~...0b6ed42 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manageiq-providers-amazon/app/models/manageiq/providers/amazon/agent_coordinator.rb
Line 3 in a22095f
ManageIQ::ApplianceConsole was pulling in this dependency for us but if zeitwerk
autoloads this provider first, the gem dependency doesn't exist yet.
See: https://github.com/ManageIQ/manageiq-appliance_console/blob/master/manageiq-appliance_console.gemspec#L32
Additionally, consolidate the gem loader to the one in the namespaced directory location.