Fixed massage emsrefresh completed successfully

[galoiring]

currently there's no dedicated success message for propagating success from autosde backend to miq_task.
we only get an EmsRefresh success msg like:

After the changes we made it looks like this :

Related PR:

• Core: Fixed massage emsrefresh completed successfully manageiq#22465

[Fryguy]

Minor style, but can you trim these multiple blank lines to a single blank line?

[agrare]

It seems weird that the "action" would be "completed successfully", it does look like we could improve the task message though the targets aren't very helpful when they aren't class+id pairs.

Also this isn't autosde specific so if we're going to change the task probably should just be done here https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh.rb#L169-L172

[galoiring]

It seems weird that the "action" would be "completed successfully", it does look like we could improve the task message though the targets aren't very helpful when they aren't class+id pairs.

Also this isn't autosde specific so if we're going to change the task probably should just be done here https://github.com/ManageIQ/manageiq/blob/master/app/models/ems_refresh.rb#L169-L172

If all the other providers does queue their task it will be fine.
whatever you decide

[agrare]

Yes all providers use this, lets focus on the core PR and see if we can clean up how we log the targets. I don't think we should say that the action is "EmsRefresh completed successfully " though since that doesn't make sense.

[miq-bot]

Checked commit Autosde@24a22ba with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 4 offenses detected

app/models/manageiq/providers/autosde/storage_manager/ems_refresh_workflow.rb

• ❗ - Line 83, Col 1 - Layout/EmptyLinesAroundMethodBody - Extra empty line detected at method body end.
• ❗ - Line 86, Col 34 - Naming/MethodParameterName - Method parameter must be at least 3 characters long.
• ❗ - Line 95, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 96, Col 1 - Layout/EmptyLines - Extra blank line detected.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

alt: ManageIQ/manageiq#22776