Fixed massage emsrefresh completed successfully #22465
Conversation
galoiring
changed the title
|
@agrare so we can fix this here in the core repo |
|
Checked commit Autosde@812487d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/models/ems_refresh.rb
|
| def self.queue_refresh_task(target, id = nil) | ||
| queue_refresh(target, id, :create_task => true) | ||
| def self.queue_refresh_task(targets, id = nil) | ||
| queue_refresh(targets, id, :create_task => true) |
There was a problem hiding this comment.
I thought it would be more accurate because it is a list of targets
|
@galoiring if you want to clean up how the targets are listed in the task message for the |
it isn't something that was bother me (just plural instead of singular) but if it needed I would do that |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
taken from: - ManageIQ#22465 - ManageIQ/manageiq-providers-autosde#228 Instead of displaying target information, this now displays a user friendly message in the ui
|
alt: #22776 |
taken from: - ManageIQ#22465 - ManageIQ/manageiq-providers-autosde#228 Instead of displaying target information, this now displays a quick user friendly summary
taken from: - ManageIQ#22465 - ManageIQ/manageiq-providers-autosde#228 Instead of displaying target information, this now displays a quick user friendly summary
currently there's no dedicated success message for propagating success from autosde backend to miq_task.
we only get an EmsRefresh success msg like:
After the changes we made it looks like this :
