Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement raw_destroy for LPARs #127

Merged
merged 4 commits into from Dec 2, 2022
Merged

implement raw_destroy for LPARs #127

merged 4 commits into from Dec 2, 2022

Conversation

dberg1
Copy link
Contributor

@dberg1 dberg1 commented Nov 28, 2022

image

@dberg1 dberg1 changed the title implement raw_destroy for LPARs [WIP] implement raw_destroy for LPARs Nov 28, 2022
@miq-bot miq-bot added the wip label Nov 28, 2022
@agrare agrare self-assigned this Nov 28, 2022
@agrare agrare added the enhancement New feature or request label Nov 28, 2022
@dberg1
Copy link
Contributor Author

dberg1 commented Nov 28, 2022

@agrare I can't see the destroy item in the menu even with the supports :terminate. Do you know if there is anything else to do? Looks like supports :destroy is already set by default.

@dberg1
Copy link
Contributor Author

dberg1 commented Nov 29, 2022

Damien Bergamini added 4 commits November 29, 2022 12:58
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2022

Checked commits https://github.com/dberg1/manageiq-providers-ibm_power_hmc/compare/182f73fd0f02d9a92f122f28afaa1c20f17c6245~...0d9863d0f4fa4882a203dd109441c54b99082bf9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@dberg1 dberg1 changed the title [WIP] implement raw_destroy for LPARs implement raw_destroy for LPARs Dec 1, 2022
@miq-bot miq-bot removed the wip label Dec 1, 2022
@agrare agrare merged commit e2a8fd2 into ManageIQ:master Dec 2, 2022
@dberg1 dberg1 deleted the destroy branch December 5, 2022 07:58
@Fryguy Fryguy added this to the Petrosian milestone Sep 14, 2023
@Fryguy Fryguy added this to Petrosian in Roadmap Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
  
Petrosian
Development

Successfully merging this pull request may close these issues.

None yet

4 participants