Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deletion of VMs in infra manager #8551

Merged
merged 2 commits into from
Dec 2, 2022
Merged

allow deletion of VMs in infra manager #8551

merged 2 commits into from
Dec 2, 2022

Conversation

dberg1
Copy link
Contributor

@dberg1 dberg1 commented Nov 29, 2022

It is currently not possible to delete a VM with infra provider.
This would be useful for HMC provider, see ManageIQ/manageiq-providers-ibm_power_hmc#127.
This PR adds the following menu item:

image

Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@jeffibm
Copy link
Member

jeffibm commented Nov 30, 2022

Hey @dberg1,

For testing, I tried loading the ui-classic, ibm-power-hmc, manageiq repo Pr's and got this error -

role_allows? no feature was found with identifier: ["vm_terminate"]. Correct the identifier or add it to miq_product_features.yml. [vm_infra/explorer]

Guess it's because the ibm-power-hmc repo is WIP.

The rest of the code looks good in classic. Let us know when it's ready to be merged.

@dberg1
Copy link
Contributor Author

dberg1 commented Dec 1, 2022

@jeffibm You also need this PR: ManageIQ/manageiq#22257

Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2022

Checked commits https://github.com/dberg1/manageiq-ui-classic/compare/153382429c5769705fe712f69c96d2cac22f9419~...1a9f8fbd22fe84105d62801b40ea23c2d0bbb0dd with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/vm_infras_center.rb

app/helpers/application_helper/toolbar/x_vm_center.rb

@agrare agrare merged commit 5844298 into ManageIQ:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants