Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow deletion of VMs in infra manager #22257

Merged
merged 1 commit into from
Dec 2, 2022
Merged

allow deletion of VMs in infra manager #22257

merged 1 commit into from
Dec 2, 2022

Conversation

dberg1
Copy link
Contributor

@dberg1 dberg1 commented Nov 29, 2022

Related to this PR: ManageIQ/manageiq-ui-classic#8551

allow deletion of VMs in infra manager
76caf72 
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@dberg1 dberg1 mentioned this pull request Nov 29, 2022
Merged
@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2022

Checked commit https://github.com/dberg1/manageiq/commit/76caf7214fcdad5f5383606bb34da8ccd8d2df95 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare self-assigned this Nov 30, 2022
@dberg1 dberg1 mentioned this pull request Dec 1, 2022
Merged
@agrare
Copy link
Member

agrare commented Dec 2, 2022

@dberg1 can you also add this to the set of miq_product_feature_identifiers for the EvmRole-operator user role in db/fixtures/miq_user_roles.yml ?

agrare
agrare approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, previously you had to retire a VM to be able to delete it but direct control is a nice option especially if the retire state machine only powers off the VM if we didn't provision it.

We can add the user role in a follow-up

@agrare agrare merged commit 131a0af into ManageIQ:master Dec 2, 2022
@dberg1 dberg1 mentioned this pull request Dec 5, 2022
Merged
@dberg1 dberg1 deleted the vm_terminate branch December 5, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@agrare agrare

Labels
enhancement providers/virtual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dberg1 @miq-bot @agrare