Replaces missing Inventory::Builder in refresh runner #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inventory.build is used instead Inventory::Builder.build_full Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632131
|
@miq-bot add_label bug |
|
Checked commit slemrmartin@a021065 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
pkliczewski
reviewed
Sep 25, 2018
| parser, collector = ManageIQ::Providers::Kubevirt::Builder.build_full(manager, persister) | ||
|
|
||
| # execute parse and persist: | ||
| parser.parse |
There was a problem hiding this comment.
Where do we run it now?
There was a problem hiding this comment.
Inventory.new calls parser.parse
pkliczewski
reviewed
Sep 25, 2018
slemrmartin
changed the title
|
@pkliczewski just verified, it's working. |
|
@miq-bot add_label hammer/yes |
simaishi
pushed a commit
that referenced
this pull request
Oct 1, 2018
Replaces missing Inventory::Builder in refresh runner (cherry picked from commit 30a0ba1) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632131
|
Hammer backport details: |
2 tasks
pkliczewski
added a commit
to pkliczewski/manageiq-providers-kubevirt
that referenced
this pull request
Dec 7, 2018
With recent change [1] we introduced this regression where we stopped calling parser. This PR fixes the issue. Fixes: https://bugzilla.redhat.com/1649629 [1] ManageIQ#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full refresh fails in
ManageIQ::Providers::Kubevirt::InfraManager::RefreshWorker::Runner.ManageIQ::Providers::Inventory.buildshould be used instead ofManageIQ::Providers::Inventory::Kubevirt::Builder.build_full, which was removed.Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1632131
caused by PR: #115
Steps to reproduce:
Click on Refresh on Kubevirt provider