Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh: Parser was never called #126

Merged
merged 1 commit into from
Dec 7, 2018
Merged

refresh: Parser was never called #126

merged 1 commit into from
Dec 7, 2018

Conversation

pkliczewski
Copy link
Contributor

With recent change [1] we introduced this regression where we stopped calling
parser. This PR fixes the issue.

Fixes: https://bugzilla.redhat.com/1649629

[1] #117

@pkliczewski
refresh: Parser was never called
8bb00da 
With recent change [1] we introduced this regression where we stopped calling
parser. This PR fixes the issue.

Fixes: https://bugzilla.redhat.com/1649629

[1] ManageIQ#117
@pkliczewski
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Dec 7, 2018
@pkliczewski
Copy link
Contributor Author

@miq-bot add_label hammer/yes

@pkliczewski
Copy link
Contributor Author

fyi @slemrmartin

@agrare agrare self-assigned this Dec 7, 2018
@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2018

Checked commit pkliczewski@8bb00da with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

agrare
agrare approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare
Copy link
Member

agrare commented Dec 7, 2018

cc @Ladas

@agrare agrare merged commit 8bb00da into ManageIQ:master Dec 7, 2018
agrare added a commit that referenced this pull request Dec 7, 2018
@agrare
Merge pull request #126 from pkliczewski/master
0392c06 
refresh: Parser was never called
@agrare agrare added the blocker label Dec 7, 2018
@agrare agrare added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 7, 2018
@pkliczewski
Copy link
Contributor Author

@agrare Thank you for helping with this one.

simaishi pushed a commit that referenced this pull request Dec 7, 2018
@agrare @simaishi
Merge pull request #126 from pkliczewski/master
0c7dd9b 
refresh: Parser was never called
(cherry picked from commit 0392c06)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649629
@simaishi
Copy link

simaishi commented Dec 7, 2018

Hammer backport details:

$ git log -1
commit 0c7dd9b8745686028836d918909dfd43cb13b9f3
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Dec 7 11:20:25 2018 -0500

    Merge pull request #126 from pkliczewski/master
    
    refresh: Parser was never called
    (cherry picked from commit 0392c063ce89c1c4bcb225ea6868e660d6ee95c8)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@masayag masayag Awaiting requested review from masayag

Assignees

@agrare agrare

Labels
blocker bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkliczewski @miq-bot @agrare @simaishi