drop unsupported_reason_add and supports_event?

[kbrock]

• Deprecating unsupported_reason_add. Returning the string instead
• update to no longer use supports_events?

part of:

• Drop Supports' unsupports variable manageiq#22898

[kbrock]

update:

• fixed indentation
• fixed paren in resize
• rubocop [], unless else
• dropped supports_events? => supports(:events) { ems.unsupported_reason }

update:

• rubocop [], exclude?

[kbrock]

update:

• convert snapshot remove_snapshot_by_description / revert_to_snapshot to supports_not
• for cloud volume operations, convert return "" if ; return "" if to basic if ems "" ; else ""

[miq-bot]

Checked commits kbrock/manageiq-providers-openstack@b2440ed~...137c279 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
26 files checked, 0 offenses detected
Everything looks fine. 🍪

[kbrock]

@agrare:

This is a change.
before, if there is no parent_manager, then it will be good
after: if there is no parent manager, then it will bad

sound right to you?
(I obviously think so, but wanted to make this change clear)

[agrare]

Yeah, I don't think this manager could possibly work without a parent ems due to the delegated authentication so even allow_nil below probably doesn't make sense so I'm good with this.