Convert host operations to supports #804
Conversation
|
|
||
| def validate_active_with_power_state(feature, expected_power_state) | ||
| return unsupported_reason_add(feature, _("The Host is not connected to an active Provider")) unless has_active_ems? | ||
| return unsupported_reason_add(feature, _("The host is not powered '#{expected_power_state}'")) unless expected_power_state == power_state |
There was a problem hiding this comment.
"This host is not powered 'maintenance'" is going to read weird. Not sure how else to do this though.
There was a problem hiding this comment.
I agree but this is the current string, trying to not move and modify in the same change
| supports :standby do | ||
| validate_active_with_power_state(:standby, "on") | ||
| end | ||
| supports :enter_maint_mode do |
There was a problem hiding this comment.
any reason to not spell it out?
| supports :enter_maint_mode do | |
| supports :enter_maintenance_mode do |
There was a problem hiding this comment.
Wanted to keep these feature names the same https://github.com/ManageIQ/manageiq/pull/21847/files#diff-9daa2c365cb8a7cb177648fe53854dae6588080e089b01333768fcb5da8ff4aeL256
agrare
changed the title
| supports :vmotion do | ||
| validate_active_with_power_state(:vmotion, "on") | ||
| end |
There was a problem hiding this comment.
This one is a little weird, it really means "am I able to ask if vmotion is enabled" not actually checking if it is enabled might want to do this differently
agrare
force-pushed
the
convert_host_operations_to_supports
branch
2 times, most recently
from
76d1f1f
to
6810b9e
Compare
agrare
changed the title
agrare
force-pushed
the
convert_host_operations_to_supports
branch
from
6810b9e
to
23b0ab4
Compare
|
Checked commits agrare/manageiq-providers-vmware@26c18e4~...23b0ab4 with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
Required for: