Pass the workflow service account #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Oct 12, 2023
| "token_file" => "/run/secrets/kubernetes.io/serviceaccount/token", | ||
| "ca_cert" => "/run/secrets/kubernetes.io/serviceaccount/ca.crt", | ||
| "namespace" => File.read("/run/secrets/kubernetes.io/serviceaccount/namespace"), | ||
| "workflow_service_account" => "manageiq-default" |
There was a problem hiding this comment.
This value can be productized using the app name in the CR, so it may not always be "manageiq"
There was a problem hiding this comment.
Moved to an ENV var AUTOMATION_JOB_SERVICE_ACCOUNT
Fryguy
force-pushed
the
add_workflow_service_account
branch
2 times, most recently
from
9e7ebe2
to
154677e
Compare
2 tasks
Fryguy
force-pushed
the
add_workflow_service_account
branch
from
154677e
to
cddce53
Compare
Fryguy
force-pushed
the
add_workflow_service_account
branch
from
cddce53
to
61ae5dc
Compare
|
Checked commits Fryguy/manageiq-providers-workflows@61ae5dc~...74af26d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Oct 12, 2023
Pass the workflow service account (cherry picked from commit d73c48c)
Fryguy
added a commit
to ManageIQ/manageiq
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agrare @bdunne @kbrock Please review.
This PR hardcodes the value for now, but it should probably be passed down as an ENV var. Not sure if we want to do this now or later. @bdunne Thoughts?
Depends on
Must be merged with