Always treat id as string, never a number (in JS)

[himdel]

Right now, some places treat entity ids as numbers, some as strings.

And that would be fine if the max region number were 9006. But unfortunately that's not the case, @tzumainn recently encountered an id looking like 58015000000000001 (so, region = 58015), which is bigger than 9007199254740991 (Number.MAX_SAFE_INTEGER in JS (ref)).

Thus, if we need to support regions over 9006, the UI needs to treat every id as a string, never a number.
Furthermore, we'll need the API to never send a number and always convert to a string.

[himdel]

Additional info from ☝️ May 22, 2017 5:31 PM...

https://github.com/ManageIQ/manageiq-gems-pending/blob/master/lib/gems/pending/appliance_console/database_configuration.rb#L30

REGION_RANGE = 0..9223371

# PG 9.2 bigint max 9223372036854775807 / ArRegion::DEFAULT_RAILS_SEQUENCE_FACTOR = 9223372
# http://www.postgresql.org/docs/9.2/static/datatype-numeric.html
# 9223372 won't be a full region though, so we're not including it.

[Fryguy]

Aside, I believe the REST API always does this anyway for the same reason.

[himdel]

Right now, the REST API is sending numbers in the JSON, not strings :( .. but @abellotti mentioned a plan to make API send cids instead of those numbers. (Alberto, is there anything ..trackable we can link from here?)

[abellotti]

just added this: https://www.pivotaltracker.com/story/show/146613947

Thanks,

/cc @imtayadeway @jntullo @gtanzillo

[Fryguy]

Right now, the REST API is sending numbers in the JSON, not strings :( .. but @abellotti mentioned a plan to make API send cids instead of those numbers. (Alberto, is there anything ..trackable we can link from here?)

Oh wow that's super surprising...I brought this up very early on in the development of the API 😕

[himdel]

(PR: ManageIQ/manageiq#15430 )

[himdel]

(Also related: #3243, but that PR gives me a 500 right now.)