Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The id returned by report_data() is now a string #2916

Merged
merged 1 commit into from
Dec 4, 2017
Merged

The id returned by report_data() is now a string #2916

merged 1 commit into from
Dec 4, 2017

Conversation

mzazrivec
Copy link
Contributor

The behavior changed in 716037a and PR #2902

@miq-bot
Copy link
Member

miq-bot commented Dec 4, 2017

Checked commit mzazrivec@8250ba2 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny
Copy link
Member

martinpovolny commented Dec 4, 2017 •
edited
Loading

Yes, it's a cross merge issue.

@simaishi : please, make sure to backport this one with #2902

Waiting for travis....

@martinpovolny
Copy link
Member

Restarted failed travis task.

@martinpovolny martinpovolny merged commit f18a28f into ManageIQ:master Dec 4, 2017
@martinpovolny martinpovolny added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@martinpovolny @simaishi
Merge pull request #2916 from mzazrivec/fix_ci_failure_after_pr_2902
a58b069 
The id returned by report_data() is now a string
(cherry picked from commit f18a28f)
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit a58b06980e32951bb38d6ef74066d911af81250c
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Dec 4 10:54:23 2017 +0100

    Merge pull request #2916 from mzazrivec/fix_ci_failure_after_pr_2902
    
    The id returned by report_data() is now a string
    (cherry picked from commit f18a28f2a46ad723739cb7d67139b7dc88f27477)

@mzazrivec mzazrivec deleted the fix_ci_failure_after_pr_2902 branch February 22, 2018 12:10
@himdel
Copy link
Contributor

himdel commented Aug 3, 2018

issue: #1405

@JPrause
Copy link
Member

JPrause commented Oct 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocker gaprindashvili/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mzazrivec @miq-bot @martinpovolny @simaishi @himdel @JPrause