Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent_id being a number, not string in JS #4399

Merged
merged 5 commits into from
Aug 2, 2018
Merged

Fix parent_id being a number, not string in JS #4399

merged 5 commits into from
Aug 2, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Aug 1, 2018

Related to #3243 and #4397 and #2902.

Trying to make sure parent_id always ends up as a string in JS, not a number.

https://bugzilla.redhat.com/show_bug.cgi?id=1610353

Cc @skateman

@mzazrivec
Copy link
Contributor

@himdel The CI failure seems related. Also, could you please fix the rubocop warning above? Thanks.

@himdel
Copy link
Contributor Author

himdel commented Aug 2, 2018

Thanks, should be fixed now :)

@mzazrivec
Copy link
Contributor

Still failing in spec/controllers/storage_controller_spec.rb:305 and spec/controllers/storage_controller_spec.rb:253 .

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/f49bafae5cf164cdbb5e7447ed5c115ca4a7e26c~...bbadd37504e0f08dc169eaeab61cc3a8d51a1098 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel
Copy link
Contributor Author

himdel commented Aug 2, 2018

Not anymore :) whew :)

@mzazrivec mzazrivec self-assigned this Aug 2, 2018
@mzazrivec mzazrivec added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 2, 2018
@mzazrivec mzazrivec merged commit f6c97ab into ManageIQ:master Aug 2, 2018
@himdel himdel deleted the fix-parent-id branch August 2, 2018 15:37
@himdel
Copy link
Contributor Author

himdel commented Aug 3, 2018

issue: #1405

@JPrause
Copy link
Member

JPrause commented Oct 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Oct 3, 2018
simaishi pushed a commit that referenced this pull request Oct 5, 2018
@mzazrivec @simaishi
Merge pull request #4399 from himdel/fix-parent-id
bd54efa 
Fix parent_id being a number, not string in JS

(cherry picked from commit f6c97ab)

https://bugzilla.redhat.com/show_bug.cgi?id=1613333
@simaishi
Copy link
Contributor

simaishi commented Oct 5, 2018

Gaprindashvili backport details:

$ git log -1
commit bd54efaf0231442e8fab1073d3a0e3ad8b612099
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 2 17:26:36 2018 +0200

    Merge pull request #4399 from himdel/fix-parent-id
    
    Fix parent_id being a number, not string in JS
    
    (cherry picked from commit f6c97ab3485840ea13c55be8aec645a50f19c1e6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1613333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
blocker bug gaprindashvili/backported services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@himdel @mzazrivec @miq-bot @JPrause @simaishi