Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage service edit mode: check which attached resources are compliant to selected capabilities #8749

Closed
5 tasks done
OrGur1987 opened this issue Apr 10, 2023 · 2 comments
Closed
5 tasks done
Assignees
Projects
Milestone

Comments

@OrGur1987
Copy link
Contributor

OrGur1987 commented Apr 10, 2023

added a button in service edit mode which enables the user to check what currently attached resources will comply with the selected capabilities.

this includes a new async-action-button.jsx which is based on async-credentials.jsx, and enables sending an async request to the provider's backend and display the resolved results (or an error message if needed).

if there's a way to beautify the returning string, or even render it in a table, it could be a great improvement.

the enhancement is based on the yet to be merged #8728, and should be rebased on master after that issue is merged.

  • note: there's a DOM error/warning inherited from the above issue, relating to the resolveProps which is used to generate fields from the model. this does not occur in cloud_volumes model/form which uses resolveProps in the same way, and I would appreciate help with getting rid of this

PRs:

in the video:

  • checking compliance for the edited service without changing its current capabilities initially returns the same resources as those currently attached.
  • after changing to a capability which isn't supported by any of those resources, the action returns an error/warning message.
  • had the resource "test_pool_dr" been attached to the edited service, it would have returned as the only compliant resource.
Screen.Recording.2023-04-10.at.13.40.27.mov
@agrare
Copy link
Member

agrare commented Jun 5, 2023

@Fryguy what are we doing with issues that we don't want to backport wrt the roadmap? There isn't a Quinteros milestone yet.

@Fryguy
Copy link
Member

Fryguy commented Jun 5, 2023

Oh I'll make one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
  
Quinteros
Development

No branches or pull requests

3 participants