New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage service edit mode: check which attached resources are compliant to selected capabilities #1218
storage service edit mode: check which attached resources are compliant to selected capabilities #1218
Conversation
@miq-bot cross-repo-tests ManageIQ/manageiq#22450 |
From Pull Request: ManageIQ/manageiq-api#1218
cross repo passed: |
c0e2d6b
to
3002692
Compare
@miq-bot cross-repo-tests ManageIQ/manageiq#22450 |
From Pull Request: ManageIQ/manageiq-api#1218
3002692
to
34b8e00
Compare
@miq-bot cross-repo-tests ManageIQ/manageiq#22450 |
From Pull Request: ManageIQ/manageiq-api#1218
def check_compliant_resources_resource(type, _id = nil, data = {}) | ||
data["_id"] = _id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely want to use id
and not _id
Also, do we want data["id"]
or is that underscore correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem changing the method param name to id
, but changing the data
hash key to id
raises the following error in api_ems_resource
: Resource id or href should not be specified for creating a new storage_services
.
perhaps I shouldn't have used api_ems_resource
if it's intended for creating new records only?
I used it because it appeared in the existing validate
action that I based upon:
def validate_resource(type, _id = nil, data = {}) |
is there an alternative?
if data["_id"]
can stay that way, I prefer using api_ems_resource
since things are working right now..
thanks
34b8e00
to
9fd3066
Compare
…rrently attached resources will comply with the selected capabilities.
9fd3066
to
8b1dc51
Compare
Checked commit Autosde@8b1dc51 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
issue: ManageIQ/manageiq-ui-classic#8749
added button in service edit mode which enables user to check what currently attached resources will comply with the selected capabilities.
this PR adds the action to the api controller and to api.yml