Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage service edit mode: check which attached resources are compliant to selected capabilities #22450

Conversation

OrGur1987
Copy link
Contributor

issue: ManageIQ/manageiq-ui-classic#8749

added button in service edit mode which enables user to check what currently attached resources will comply with the selected capabilities.

this PR adds the necessary methods for this action in the main storage_service model and in miq_product_features

@agrare
Copy link
Member

agrare commented Apr 10, 2023

@OrGur1987 I think we're misusing the check_compliance feature here, if this isn't the same thing that is being implemented by the ComplianceMixin then we should come up with a different feature name.

@OrGur1987
Copy link
Contributor Author

@OrGur1987 I think we're misusing the check_compliance feature here, if this isn't the same thing that is being implemented by the ComplianceMixin then we should come up with a different feature name.

I can change it to check_compliant_resources in all related changes across the repos.

@OrGur1987
Copy link
Contributor Author

@OrGur1987 I think we're misusing the check_compliance feature here, if this isn't the same thing that is being implemented by the ComplianceMixin then we should come up with a different feature name.

I can change it to check_compliant_resources in all related changes across the repos.

@agrare should I?

…rrently attached resources will comply with the selected capabilities.
@OrGur1987 OrGur1987 force-pushed the add_resource_compliance_check_to_service_update branch from cee4bd9 to d710102 Compare April 17, 2023 18:38
@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2023

Checked commit Autosde@d710102 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 1 offense detected

db/fixtures/miq_product_features.yml

  • 💣 💥 🔥 🚒 - Line 5141, Col 3 - key-duplicates - duplication of key ":description" in mapping

@OrGur1987
Copy link
Contributor Author

@agrare
changed action name
should I remove the dup line here? (asked u in another PR too)
#22450 (comment)

@kbrock
Copy link
Member

kbrock commented May 2, 2023

lol. I was going to ask if we could use an existing feature instead of adding one. Then I read the thread.

This is just a validate before this resource (is attempted to be) created. So it seems like it could leverage the create feature.

LGTM :shipit:

@agrare agrare merged commit 19848c9 into ManageIQ:master May 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants