Move the Ansible Tower UI to the Automation tab

[lgalis]

Add the Ansible Tower UI to the Automation Tab.

---

Depends on ManageIQ/manageiq#13526 - will remove the WIP label after 13526 is merged.

This PR moves the Ansible Tower UI from the Configuration tab to the Automation Tab.
It uses the new AutomationManager model for Ansible introduced in PR #13630.

Links:

https://www.pivotaltracker.com/n/projects/1937457

[lgalis]

@miq-bot add_label wip

[chessbyte]

Please rename configmgr to configuration_manager

[lgalis]

@dclarizio , @h-kataria - please review - Please note that this PR needs ManageIQ/manageiq#13526.

[dclarizio]

@martinpovolny added you as a reviewer to check for any of the currenty UI refactoring patterns that @lgalis could apply either in this PR or in a follow up.

[lgalis]

@martinpovolny - just FYI - the AnsibleTower::ConfigurationManager will be changed to AnsibleTower::AutomationManager after the PR 13630 is merged.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commits lgalis/manageiq-ui-classic@a90de89~...83d5e5c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
34 files checked, 106 offenses detected

app/controllers/application_controller/ci_processing.rb

• ❕ - Line 1947, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for manager_button_operation is too high. [27.73/20]
• ❕ - Line 1947, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for manager_button_operation is too high. [7/6]
• ❕ - Line 1947, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for manager_button_operation is too high. [10/7]
• ❕ - Line 1966, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for process_managers is too high. [23.75/20]

app/controllers/application_controller/filter.rb

• ❕ - Line 514, Col 121 - Metrics/LineLength - Line is too long. [122/120]

app/controllers/automation_manager_controller.rb

• ❕ - Line 123, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for automation_manager_form_fields is too high. [24.17/20]
• ❕ - Line 140, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for load_or_clear_adv_search is too high. [30.23/20]
• ❕ - Line 140, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for load_or_clear_adv_search is too high. [10/6]
• ❕ - Line 140, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for load_or_clear_adv_search is too high. [11/7]
• ❕ - Line 182, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for automation_manager_providers_tree_rec is too high. [7/6]
• ❕ - Line 1, Col 1 - Metrics/ClassLength - Class has too many lines. [506/100]
• ❕ - Line 212, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for show_record is too high. [24.23/20]
• ❕ - Line 212, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for show_record is too high. [12/6]
• ❕ - Line 212, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for show_record is too high. [10/7]
• ❕ - Line 290, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for get_node_info is too high. [28.3/20]
• ❕ - Line 290, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for get_node_info is too high. [13/6]
• ❕ - Line 290, Col 3 - Metrics/MethodLength - Method has too many lines. [29/25]
• ❕ - Line 290, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for get_node_info is too high. [11/7]
• ❕ - Line 314, Col 121 - Metrics/LineLength - Line is too long. [156/120]
• ❕ - Line 340, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• ❕ - Line 384, Col 121 - Metrics/LineLength - Line is too long. [135/120]
• ❕ - Line 453, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for update_partials is too high. [29.14/20]
• ❕ - Line 453, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for update_partials is too high. [8/6]
• ❕ - Line 453, Col 3 - Metrics/MethodLength - Method has too many lines. [27/25]
• ❕ - Line 453, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for update_partials is too high. [10/7]
• ❕ - Line 533, Col 121 - Metrics/LineLength - Line is too long. [154/120]
• ❕ - Line 560, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for configscript_service_dialog_submit_save is too high. [22.58/20]
• ❕ - Line 58, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for edit is too high. [20.78/20]
• ❕ - Line 75, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for delete is too high. [30.22/20]
• ❕ - Line 79, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 81, Col 121 - Metrics/LineLength - Line is too long. [136/120]

app/controllers/mixins/manager_controller_mixin.rb

• ❗ - Line 2, Col 3 - Metrics/ModuleLength - Module has too many lines. [376/100]
• ❕ - Line 102, Col 121 - Metrics/LineLength - Line is too long. [134/120]
• ❕ - Line 126, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for cs_edit_get_form_vars is too high. [21.75/20]
• ❕ - Line 144, Col 5 - Metrics/CyclomaticComplexity - Cyclomatic complexity for show is too high. [8/6]
• ❕ - Line 144, Col 5 - Metrics/PerceivedComplexity - Perceived complexity for show is too high. [9/7]
• ❕ - Line 182, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for accordion_select is too high. [22.8/20]
• ❕ - Line 32, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for save_provider is too high. [29.34/20]
• ❕ - Line 338, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for apply_node_search_text is too high. [27.46/20]
• ❕ - Line 348, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for setup_search_text_for_node is too high. [24.33/20]
• ❕ - Line 351, Col 121 - Metrics/LineLength - Line is too long. [150/120]
• ❕ - Line 363, Col 5 - Metrics/CyclomaticComplexity - Cyclomatic complexity for handle_bottom_cell is too high. [8/6]
• ❕ - Line 363, Col 5 - Metrics/PerceivedComplexity - Perceived complexity for handle_bottom_cell is too high. [11/7]
• ❕ - Line 386, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for rebuild_toolbars is too high. [25.79/20]
• ❕ - Line 386, Col 5 - Metrics/CyclomaticComplexity - Cyclomatic complexity for rebuild_toolbars is too high. [10/6]
• ❕ - Line 386, Col 5 - Metrics/PerceivedComplexity - Perceived complexity for rebuild_toolbars is too high. [10/7]
• ❕ - Line 82, Col 5 - Metrics/AbcSize - Assignment Branch Condition size for explorer is too high. [35.14/20]

app/controllers/provider_foreman_controller.rb

• ❕ - Line 274, Col 121 - Metrics/LineLength - Line is too long. [171/120]
• ❕ - Line 332, Col 121 - Metrics/LineLength - Line is too long. [159/120]
• ❕ - Line 406, Col 121 - Metrics/LineLength - Line is too long. [213/120]

app/helpers/application_helper.rb

• ❕ - Line 266, Col 121 - Metrics/LineLength - Line is too long. [172/120]

app/helpers/application_helper/toolbar/automation_manager_provider_center.rb

• ❗ - Line 36, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 37, Col 3 - Style/ClosingParenthesisIndentation - Align ) with (.
• ❗ - Line 37, Col 3 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.
• ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/automation_manager_providers_center.rb

• ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 54, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 55, Col 3 - Style/ClosingParenthesisIndentation - Align ) with (.
• ❗ - Line 55, Col 3 - Style/MultilineMethodCallBraceLayout - Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument.

app/helpers/application_helper/toolbar/configured_system/automation_policy_mixin.rb

• ❗ - Line 22, Col 6 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 4, Col 8 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/x_automation_manager_ansible_tower_configured_system_center.rb

• ❕ - Line 1, Col 121 - Metrics/LineLength - Line is too long. [122/120]

app/helpers/application_helper/toolbar_chooser.rb

• ❕ - Line 102, Col 121 - Metrics/LineLength - Line is too long. [147/120]

app/helpers/automation_manager_helper.rb

• ❗ - Line 1, Col 1 - Metrics/ModuleLength - Module has too many lines. [109/100]
• ❕ - Line 97, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for textual_survey_group is too high. [21.12/20]

app/presenters/menu/default_menu.rb

• ❗ - Line 223, Col 11 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❕ - Line 223, Col 121 - Metrics/LineLength - Line is too long. [167/120]
• ❕ - Line 224, Col 121 - Metrics/LineLength - Line is too long. [156/120]

app/presenters/tree_builder_automation_manager_configuration_scripts.rb

• ❕ - Line 32, Col 121 - Metrics/LineLength - Line is too long. [155/120]

app/presenters/tree_builder_automation_manager_providers.rb

• ❕ - Line 25, Col 121 - Metrics/LineLength - Line is too long. [152/120]

spec/controllers/automation_manager_controller_spec.rb

• ❗ - Line 112, Col 3 - Metrics/BlockLength - Block has too many lines. [36/25]
• ❗ - Line 1, Col 1 - Metrics/BlockLength - Block has too many lines. [513/25]
• ❗ - Line 266, Col 3 - Metrics/BlockLength - Block has too many lines. [93/25]
• ❗ - Line 286, Col 5 - Metrics/BlockLength - Block has too many lines. [38/25]
• ❗ - Line 453, Col 3 - Metrics/BlockLength - Block has too many lines. [29/25]
• ❗ - Line 520, Col 3 - Metrics/BlockLength - Block has too many lines. [42/25]
• ❕ - Line 105, Col 121 - Metrics/LineLength - Line is too long. [122/120]
• ❕ - Line 11, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• ❕ - Line 12, Col 121 - Metrics/LineLength - Line is too long. [128/120]
• ❕ - Line 14, Col 121 - Metrics/LineLength - Line is too long. [149/120]
• ❕ - Line 15, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• ❕ - Line 16, Col 121 - Metrics/LineLength - Line is too long. [164/120]
• ❕ - Line 17, Col 121 - Metrics/LineLength - Line is too long. [155/120]
• ❕ - Line 18, Col 121 - Metrics/LineLength - Line is too long. [159/120]
• ❕ - Line 20, Col 121 - Metrics/LineLength - Line is too long. [168/120]
• ❕ - Line 210, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• ❕ - Line 21, Col 121 - Metrics/LineLength - Line is too long. [157/120]
• ❕ - Line 22, Col 121 - Metrics/LineLength - Line is too long. [161/120]
• ❕ - Line 23, Col 121 - Metrics/LineLength - Line is too long. [168/120]
• ❕ - Line 24, Col 121 - Metrics/LineLength - Line is too long. [158/120]
• ❕ - Line 257, Col 121 - Metrics/LineLength - Line is too long. [137/120]
• ❕ - Line 25, Col 121 - Metrics/LineLength - Line is too long. [161/120]
• ❕ - Line 270, Col 121 - Metrics/LineLength - Line is too long. [151/120]
• ❕ - Line 32, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• ❕ - Line 33, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• ❕ - Line 34, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• ❕ - Line 350, Col 121 - Metrics/LineLength - Line is too long. [167/120]
• ❕ - Line 359, Col 121 - Metrics/LineLength - Line is too long. [194/120]
• ❕ - Line 369, Col 121 - Metrics/LineLength - Line is too long. [181/120]
• ❕ - Line 408, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• ❕ - Line 423, Col 121 - Metrics/LineLength - Line is too long. [141/120]
• ❕ - Line 429, Col 121 - Metrics/LineLength - Line is too long. [144/120]
• ❕ - Line 45, Col 121 - Metrics/LineLength - Line is too long. [149/120]
• ❕ - Line 530, Col 121 - Metrics/LineLength - Line is too long. [153/120]
• ❕ - Line 6, Col 121 - Metrics/LineLength - Line is too long. [138/120]
• ❕ - Line 7, Col 121 - Metrics/LineLength - Line is too long. [139/120]

[epwinchell]

@lgalis I am aware of that - it was a general statement

[himdel]

When adding euwe/yes or euwe/no, please add the same to #350

[martinpovolny]

The textual summary helper functions added here seem to contain a lot of dead code :-(