Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move Ansible Tower UI to Automation tab and use Automation Model #243

Closed

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Jan 25, 2017

WIP - do not merge - test branch

@lgalis
Copy link
Contributor Author

lgalis commented Jan 25, 2017

@miq-bot add_label wip, enhancement

@lgalis lgalis force-pushed the move_ansible_to_automation_model branch from d67ba48 to fabf1f4 Compare January 25, 2017 21:01
@miq-bot
Copy link
Member

miq-bot commented Jan 25, 2017

Checked commit lgalis@fabf1f4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
20 files checked, 110 offenses detected

app/controllers/ansible_tower_controller.rb

app/controllers/application_controller/ci_processing.rb

app/controllers/provider_foreman_controller.rb

app/helpers/ansible_tower_helper.rb

app/helpers/application_helper/toolbar/ansible_tower_provider_center.rb

  • ❗ - Line 36, Col 31 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 33 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❕ - Line 32, Col 121 - Metrics/LineLength - Line is too long. [143/120]

app/helpers/application_helper/toolbar/ansible_tower_providers_center.rb

app/helpers/application_helper/toolbar/x_ansible_tower_configured_system_center.rb

  • ❗ - Line 21, Col 32 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.
  • ❗ - Line 3, Col 34 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar_chooser.rb

app/presenters/menu/default_menu.rb

app/presenters/tree_builder.rb

app/presenters/tree_builder_ansible_tower_configuration_scripts.rb

app/presenters/tree_builder_ansible_tower_providers.rb

spec/controllers/ansible_tower_controller_spec.rb

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2017

This pull request is not mergeable. Please rebase and repush.

@lgalis
Copy link
Contributor Author

lgalis commented Jan 30, 2017

Changes to use the new AutomationManager model have been added to #170. Closing this.

@lgalis lgalis closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants