travis - create manageiq/log manually #4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log is no longer present per https://github.com/ManageIQ/manageiq/pull/17663/files Manually create it This needs to happen before the last step of `bin/setup` because that part resets tests
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/2840e7ccd483a23b5a2987c278a2962b4b28631c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Moved to @kbrock Do you think maybe this should live in manageiq/lib/manageiq/environment.rb after all? |
This was referenced Aug 21, 2018
|
I'll undo this change here once that one is merged, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ManageIQ/manageiq#17663, there is no manageiq/log directory by default.
That breaks travis with
Creating the log file.
Closes #4501
@kbrock I took the liberty of replicating your PR with the log creation happening before
setup_js_env.shwhich seems to need it :)