Move log dir creation location #17886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in ab4fa87 we removed the creation of the log directory In production / appliances, we don't want an actual log directory. Unfortunatly the current solution caused issues for plugins Instead, the log creation was moved to the environment setup. So all plugins travis builds will get the benefit ManageIQ#17663
|
Checked commit kbrock@432531f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Aug 21, 2018
Fryguy
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in ab4fa87 we removed the creation of the log directory
In production / appliances, we don't want an actual
log directory.
Unfortunatly the current solution caused issues for
plugins
Instead, the log creation was moved to the environment setup.
So all plugins travis builds will get the benefit
changes #17663
ASIDE: I do wish this was parallel to the
ensure_config_filesmethod. But this method is part ofbin/setup,bin/update, and the travis build processes (both master, ui, and plugins) - so this should fix it. And it isn't too out of place. (thanks @himdel for the pointer)