-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications - fix UI performance with thousands of notifications #611
Conversation
Adding a bunch of notifications on js side.. s = angular.element($0).scope();
for (var i = 0; i < 1024; i++) {
s.notificationGroup.notifications.push({
timeStamp: new Date(),
data: {
timeStamp: new Date(),
endTime: new Date(),
startTime: new Date(),
message: "Foo!" + i,
}
});
}
s.$apply(); |
…src/notification copy of patternfly's version from patternfly/angular-patternfly#311 (before the update to uib* prefixes with new angular-ui-bootstrap)
because those work just fine in patternfly
…on to miq.notifications to prevent scope clash with the patternfly implementation
…o match what they do
because miq is using strictDi
also drop the module because it's already in angular_modules/
when seeding from the API, ask for only the last 100 notifications, instead of all of them
…hoses otherwise when notification count > 100 (in a group), the user sees only the first 100, and there's an extra button to show all of them - and to go back to showing only a 100
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/e333d14893e924138a214dcca8adbe707d44ff54~...2b58e8f025a0b24ba3364e9fec24d2e97d94598f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/static/notification_drawer/notification-drawer.html.haml |
Only the last 4 commits actually change stuff, the rest just brings in stuff from patternfly and cleans it up :). |
Notifications - fix UI performance with thousands of notifications (cherry picked from commit 40eeb17)
Fine backport details:
|
Euwe backport (to manageiq repo) details:
|
This (hopefully temporarily) moves notification area from patternfly to manageiq, and fixes it to have better performance characteristics with thousands of notifications...
WIP, now it actually uses our copy of the code, no other changes yet
https://bugzilla.redhat.com/show_bug.cgi?id=1412172
(FINE: https://bugzilla.redhat.com/show_bug.cgi?id=1448045)
(EUWE: https://bugzilla.redhat.com/show_bug.cgi?id=1448046)